Issue 1322 thermal parameters dependent temperature #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1323 +/- ##
========================================
Coverage 98.12% 98.12%
========================================
Files 272 272
Lines 15380 15431 +51
========================================
+ Hits 15091 15142 +51
Misses 289 289
Continue to review full report at Codecov.
|
brosaplanella
commented
Jan 12, 2021
brosaplanella
commented
Jan 12, 2021
brosaplanella
commented
Jan 12, 2021
valentinsulzer
requested changes
Jan 12, 2021
There was a problem hiding this comment.
Thanks @brosaplanella , just a couple of things to change / clarify
valentinsulzer
requested changes
Jan 12, 2021
| @@ -179,5 +235,45 @@ def T_amb(self, t): | |||
| "Dimensionless ambient temperature" | |||
| return (self.T_amb_dim(t) - self.T_ref) / self.Delta_T | |||
|
|
|||
| def rho_cn(self, T): | |||
| "Dimensionless negative current collector density" | |||
| return self.rho_cn_dim(T) * self.c_p_cn_dim(T) / self.rho_eff_dim(self.T_ref) | |||
There was a problem hiding this comment.
need to make T dimensional here and pass T_dim to the functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The thermal parameters (density, heat capacity and conductivity) can now be functions of temperature.
Fixes #1322
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: