Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1320 casadi error extrap events #1321

Conversation

brosaplanella
Copy link
Member

@brosaplanella brosaplanella commented Jan 7, 2021

Description

Added a check before running np.concatenate to avoid the error.

Fixes #1320

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #1321 (b4a584e) into develop (562e14a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1321   +/-   ##
========================================
  Coverage    98.11%   98.11%           
========================================
  Files          272      272           
  Lines        15340    15346    +6     
========================================
+ Hits         15051    15057    +6     
  Misses         289      289           
Impacted Files Coverage Δ
pybamm/solvers/casadi_solver.py 99.53% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562e14a...b4a584e. Read the comment docs.

@brosaplanella brosaplanella requested review from rtimms and valentinsulzer and removed request for rtimms January 7, 2021 13:14
@brosaplanella brosaplanella merged commit 943f418 into pybamm-team:develop Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casadi fails if there are extrapolation events but no termination events
2 participants