-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1251 fix function parameter diff bug #1294
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1294 +/- ##
========================================
Coverage 98.15% 98.15%
========================================
Files 272 272
Lines 15600 15622 +22
========================================
+ Hits 15312 15334 +22
Misses 288 288
Continue to review full report at Codecov.
|
Coverage error is something that was already failing before ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks Tino!
# one to differentiate it from the electrolyte concentration inside the | ||
# This is a bit of a hack, but we need to wrap electrolyte concentration with | ||
# the NotConstant class | ||
# to differentiate it from the electrolyte concentration inside the | ||
# surface potential difference when taking j.diff(c_e) later on | ||
# use explicit Multiplication instead of * to avoid simplification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this line be removed now?
…51-diff-function-parameter
Description
Fixes #1251
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: