Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1249 docs #1250

Merged
merged 2 commits into from
Nov 17, 2020
Merged

#1249 docs #1250

merged 2 commits into from
Nov 17, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Nov 17, 2020

Description

add docs and citations for cracking models

Fixes #1249

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms rtimms requested a review from brosaplanella November 17, 2020 10:08
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #1250 (5cf83dc) into develop (4e59c6b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1250   +/-   ##
========================================
  Coverage    98.01%   98.01%           
========================================
  Files          264      264           
  Lines        14731    14733    +2     
========================================
+ Hits         14439    14441    +2     
  Misses         292      292           
Impacted Files Coverage Δ
...m/models/full_battery_models/base_battery_model.py 99.67% <ø> (ø)
...s/submodels/particle_cracking/crack_propagation.py 100.00% <ø> (ø)
.../models/submodels/particle_cracking/no_cracking.py 100.00% <ø> (ø)
...odels/submodels/particle_cracking/base_cracking.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e59c6b...5cf83dc. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a very minor comment. Thanks Rob!

title = {Electrochemical Thermal-Mechanical Modelling of Stress Inhomogeneity in Lithium-Ion Pouch Cells},
journal = {Journal of The Electrochemical Society},
abstract = {Whilst extensive research has been conducted on the effects of temperature in lithium-ion batteries, mechanical effects have not received as much attention despite their importance. In this work, the stress response in electrode particles is investigated through a pseudo-2D model with mechanically coupled diffusion physics. This model can predict the voltage, temperature and thickness change for a lithium cobalt oxide-graphite pouch cell agreeing well with experimental results. Simulations show that the stress level is overestimated by up to 50% using the standard pseudo-2D model (without stress enhanced diffusion), and stresses can accelerate the diffusion in solid phases and increase the discharge cell capacity by 5.4%. The evolution of stresses inside electrode particles and the stress inhomogeneity through the battery electrode have been illustrated. The stress level is determined by the gradients of lithium concentration, and large stresses are generated at the electrode-separator interface when high C-rates are applied, e.g. fast charging. The results can explain the experimental results of particle fragmentation close to the separator and provide novel insights to understand the local aging behaviors of battery cells and to inform improved battery control algorithms for longer lifetimes.}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superpicky comment here, maybe we could remove the abstract as it clutters the file and doesn't add much value to the citation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point

@rtimms rtimms merged commit b892e5f into develop Nov 17, 2020
@rtimms rtimms deleted the issue-1249-cracking-docs branch November 17, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Particle cracking docs
2 participants