-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1249 docs #1250
#1249 docs #1250
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1250 +/- ##
========================================
Coverage 98.01% 98.01%
========================================
Files 264 264
Lines 14731 14733 +2
========================================
+ Hits 14439 14441 +2
Misses 292 292
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a very minor comment. Thanks Rob!
pybamm/CITATIONS.txt
Outdated
title = {Electrochemical Thermal-Mechanical Modelling of Stress Inhomogeneity in Lithium-Ion Pouch Cells}, | ||
journal = {Journal of The Electrochemical Society}, | ||
abstract = {Whilst extensive research has been conducted on the effects of temperature in lithium-ion batteries, mechanical effects have not received as much attention despite their importance. In this work, the stress response in electrode particles is investigated through a pseudo-2D model with mechanically coupled diffusion physics. This model can predict the voltage, temperature and thickness change for a lithium cobalt oxide-graphite pouch cell agreeing well with experimental results. Simulations show that the stress level is overestimated by up to 50% using the standard pseudo-2D model (without stress enhanced diffusion), and stresses can accelerate the diffusion in solid phases and increase the discharge cell capacity by 5.4%. The evolution of stresses inside electrode particles and the stress inhomogeneity through the battery electrode have been illustrated. The stress level is determined by the gradients of lithium concentration, and large stresses are generated at the electrode-separator interface when high C-rates are applied, e.g. fast charging. The results can explain the experimental results of particle fragmentation close to the separator and provide novel insights to understand the local aging behaviors of battery cells and to inform improved battery control algorithms for longer lifetimes.} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superpicky comment here, maybe we could remove the abstract as it clutters the file and doesn't add much value to the citation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good point
Description
add docs and citations for cracking models
Fixes #1249
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: