Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix half cell bug #1133

Merged
merged 3 commits into from
Aug 27, 2020

Conversation

brosaplanella
Copy link
Member

@brosaplanella brosaplanella commented Aug 27, 2020

Description

Fixes the bug with the potential on half-cell models

Fixes #1132

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #1133 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1133      +/-   ##
===========================================
+ Coverage    97.90%   97.92%   +0.02%     
===========================================
  Files          246      247       +1     
  Lines        13572    13913     +341     
===========================================
+ Hits         13287    13625     +338     
- Misses         285      288       +3     
Impacted Files Coverage Δ
..._battery_models/lithium_ion/basic_dfn_half_cell.py 99.21% <100.00%> (+0.01%) ⬆️
pybamm/solvers/casadi_solver.py 100.00% <0.00%> (ø)
pybamm/models/standard_variables.py 100.00% <0.00%> (ø)
pybamm/meshes/one_dimensional_submeshes.py 100.00% <0.00%> (ø)
pybamm/models/submodels/particle/base_particle.py 100.00% <0.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/dfn.py 100.00% <0.00%> (ø)
...bamm/models/full_battery_models/lithium_ion/spm.py 100.00% <0.00%> (ø)
...amm/models/full_battery_models/lithium_ion/spme.py 100.00% <0.00%> (ø)
...odels/submodels/particle/fickian_many_particles.py 100.00% <0.00%> (ø)
...dels/submodels/particle/fickian_single_particle.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e296965...b349e48. Read the comment docs.

@brosaplanella brosaplanella changed the title Issue 983 half cell Fix half cell bug Aug 27, 2020
@rtimms
Copy link
Contributor

rtimms commented Aug 27, 2020

thanks @ferranbrosa ! could you update the changelog too

@brosaplanella
Copy link
Member Author

thanks @ferranbrosa ! could you update the changelog too

Done! I was about to do so, you are too efficient hahaha

@rtimms
Copy link
Contributor

rtimms commented Aug 27, 2020

haha always waiting for the next PR to turn up!

@valentinsulzer valentinsulzer merged commit e010a6b into pybamm-team:develop Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix a bug with half cell reference potential
3 participants