Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1114 r average #1118

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Issue 1114 r average #1118

merged 4 commits into from
Jul 30, 2020

Conversation

valentinsulzer
Copy link
Member

Description

  • Fix r-average to allow taking r-average of a SecondaryBroadcast
  • Add "R-averaged particle concentration" variables
  • Fix bug in spherical integral discretisation

Fixes #1114

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #1118 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1118   +/-   ##
========================================
  Coverage    97.82%   97.82%           
========================================
  Files          245      245           
  Lines        13273    13280    +7     
========================================
+ Hits         12984    12991    +7     
  Misses         289      289           
Impacted Files Coverage Δ
pybamm/expression_tree/broadcasts.py 100.00% <100.00%> (ø)
pybamm/expression_tree/unary_operators.py 100.00% <100.00%> (ø)
pybamm/models/submodels/particle/base_particle.py 100.00% <100.00%> (ø)
pybamm/spatial_methods/finite_volume.py 97.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e379b...1270afc. Read the comment docs.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Tino!

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tinosulzer !

@valentinsulzer valentinsulzer merged commit 4e4e1ab into develop Jul 30, 2020
@valentinsulzer valentinsulzer deleted the issue-1114-r-average branch July 30, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take r_average of a variable that is broadcast
3 participants