Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change input parameters from u= to params= #899

Closed
valentinsulzer opened this issue Mar 20, 2020 · 0 comments · Fixed by #905
Closed

Change input parameters from u= to params= #899

valentinsulzer opened this issue Mar 20, 2020 · 0 comments · Fixed by #905
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Will make the input clearer
valentinsulzer added a commit that referenced this issue Mar 20, 2020
@valentinsulzer
#899 change u= to params=
2c704fa
valentinsulzer added a commit that referenced this issue Mar 20, 2020
@valentinsulzer
#899 make inputs more explicit in _integrate
cd20d99
valentinsulzer added a commit that referenced this issue Mar 20, 2020
@valentinsulzer
#899 fix unit tests
a702299
@valentinsulzer valentinsulzer self-assigned this Mar 20, 2020
valentinsulzer added a commit that referenced this issue Mar 21, 2020
@valentinsulzer
#899 fix scipy events bug
cccd781
@valentinsulzer valentinsulzer mentioned this issue Mar 21, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Mar 22, 2020
@valentinsulzer
#899 changelog
0e8fdde
valentinsulzer added a commit that referenced this issue Mar 26, 2020
@valentinsulzer
#899 rob comments
f47b4b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change "u=" to "param=" and make inputs more explicit pybamm-team/PyBaMM
1 participant
@valentinsulzer