Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results folders #683

Closed
valentinsulzer opened this issue Oct 25, 2019 · 1 comment · Fixed by #761
Closed

Results folders #683

valentinsulzer opened this issue Oct 25, 2019 · 1 comment · Fixed by #761
Assignees

Comments

@valentinsulzer
Copy link
Member

Have thought about the results folder and I think a good workflow would be to have a separate repository for each set of results (e.g. paper). Then each repository can

  • Be tested on travis, or not, up to the repository owner
  • Be kept up to date with latest version of PyBaMM, or not, up to the repo owner. To freeze a specific version of PyBaMM, the repo readme can checkout a particular version, or commit hash
  • Be public or private, up to the repo owner.

Then the results folder in pybamm just gives links to different results repositories. We could host some of these on pybamm-team if we want. We can also provide a template for how to make a results repository, with optional travis tests.

Thoughts?

@Scottmar93
Copy link
Contributor

I think this is a really good idea. Make a lot sense to separate what is the core repo from individuals results and leave maintenance to results to individuals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants