Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Experiment class #658

Closed
Scottmar93 opened this issue Oct 10, 2019 · 1 comment · Fixed by #807
Closed

Add an Experiment class #658

Scottmar93 opened this issue Oct 10, 2019 · 1 comment · Fixed by #807
Assignees
Labels

Comments

@Scottmar93
Copy link
Contributor

Summary
Add an Experiment class where the user can define all thing related to the specific set up of an experiment, including:

  • initial conditions
  • cycling profile
  • SOC to concentrations calculator
  • cooling set up?

Feel free to suggest other things that should be in this

Motivation
Performing different experiments on models will be one of the main use cases of PyBaMM so we should have a clear and simple method for setting this up.

@brosaplanella
Copy link
Member

Some experiments (GITT, HPPC...) are based on applying pulses to the battery. This can be easily implemented as a time dependent current, but it would be interesting to include a pulse function so it is friendly to users who are not used to coding. This can be helpful when including it in the GUI.

@valentinsulzer valentinsulzer self-assigned this Dec 11, 2019
valentinsulzer added a commit that referenced this issue Dec 11, 2019
valentinsulzer added a commit that referenced this issue Dec 13, 2019
valentinsulzer added a commit that referenced this issue Jan 21, 2020
valentinsulzer added a commit that referenced this issue Feb 4, 2020
valentinsulzer added a commit that referenced this issue Feb 4, 2020
valentinsulzer added a commit that referenced this issue Feb 4, 2020
valentinsulzer added a commit that referenced this issue Feb 4, 2020
valentinsulzer added a commit that referenced this issue Feb 4, 2020
valentinsulzer added a commit that referenced this issue Feb 6, 2020
valentinsulzer added a commit that referenced this issue Feb 6, 2020
@valentinsulzer valentinsulzer mentioned this issue Feb 6, 2020
8 tasks
valentinsulzer added a commit that referenced this issue Feb 6, 2020
valentinsulzer added a commit that referenced this issue Feb 6, 2020
valentinsulzer added a commit that referenced this issue Feb 6, 2020
valentinsulzer added a commit that referenced this issue Feb 7, 2020
valentinsulzer added a commit that referenced this issue Feb 7, 2020
valentinsulzer added a commit that referenced this issue Feb 9, 2020
valentinsulzer added a commit that referenced this issue Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants