Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Average in secondary dimensions #632

Closed
valentinsulzer opened this issue Sep 21, 2019 · 0 comments · Fixed by #1057
Closed

Average in secondary dimensions #632

valentinsulzer opened this issue Sep 21, 2019 · 0 comments · Fixed by #1057
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Implement the average in secondary dimensions (for the finite volume spatial method).
For example, averaging c_s in x in the Fickian many particles model.
Currently, c_s is used twice instead of c_s and c_s_xav.
This change is needed for #623
@valentinsulzer valentinsulzer self-assigned this May 26, 2020
@valentinsulzer valentinsulzer mentioned this issue May 29, 2020
Closed
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 add tests
d1f53ea
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 edit Integral to allow secondary dimension
1ff131b
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 working on finite volume discretisation
3fa4fb5
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 getting the average working
25264f6
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 merge develop
fe91c2e
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 merge #1029
4e85890
valentinsulzer added a commit that referenced this issue May 30, 2020
@valentinsulzer
#632 fixing unit tests
827f96e
valentinsulzer added a commit that referenced this issue Jun 6, 2020
@valentinsulzer
#632 fixed some tests, need to be careful about broadcasts
433aa3b
valentinsulzer added a commit that referenced this issue Jun 6, 2020
@valentinsulzer
#632 fix the case where integrand evaluates on edges
f62c7d6
valentinsulzer added a commit that referenced this issue Jun 6, 2020
@valentinsulzer
#632 fix flake8
97f1d31
valentinsulzer added a commit that referenced this issue Jun 12, 2020
@valentinsulzer
#632 fix some tests, remove __getitem__
45de6f4
valentinsulzer added a commit that referenced this issue Jun 12, 2020
@valentinsulzer
#632 fixing tests
3edd39a
valentinsulzer added a commit that referenced this issue Jun 13, 2020
@valentinsulzer
#632 fix unit tests
451f766
valentinsulzer added a commit that referenced this issue Jun 14, 2020
@valentinsulzer
#632 fix examples
6a0376c
valentinsulzer added a commit that referenced this issue Jun 15, 2020
@valentinsulzer
#632 merge develop
873c943
@valentinsulzer valentinsulzer mentioned this issue Jun 15, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Jun 15, 2020
@valentinsulzer
#632 coverage
908dbdf
valentinsulzer added a commit that referenced this issue Jun 16, 2020
@valentinsulzer
#632 changelog and ferran comment
0a43a73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 632 average second dimension pybamm-team/PyBaMM
1 participant
@valentinsulzer