Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potentiostatic mode #492

Closed
rtimms opened this issue Jul 2, 2019 · 0 comments · Fixed by #751
Closed

potentiostatic mode #492

rtimms opened this issue Jul 2, 2019 · 0 comments · Fixed by #751
Assignees
@valentinsulzer

Comments

@rtimms
Copy link
Contributor

rtimms commented Jul 2, 2019

Add option to change BCs for setting potential instead of current
valentinsulzer pushed a commit that referenced this issue Jul 12, 2019
@Scottmar93
#492 added potentiostatic option to dfn
3ef3e59
valentinsulzer pushed a commit that referenced this issue Jul 12, 2019
@Scottmar93
#492 added get voltage classes
fcf7553
valentinsulzer pushed a commit that referenced this issue Jul 12, 2019
@Scottmar93
#492 pulled in mcmb file with activation energies
c50eaab
valentinsulzer pushed a commit that referenced this issue Jul 12, 2019
@Scottmar93
#492 added voltage getters to parameter values
2d6248d
valentinsulzer pushed a commit that referenced this issue Jul 25, 2019
@Scottmar93
#492 merged from master
47b6db0
valentinsulzer pushed a commit that referenced this issue Jul 25, 2019
@Scottmar93
#492 potentiostatic passses tests with some hacky bits
8e2bf90
valentinsulzer pushed a commit that referenced this issue Jul 25, 2019
@Scottmar93
#492 fixed some unit tests
78c563e
valentinsulzer pushed a commit that referenced this issue Jul 25, 2019
@Scottmar93
#492 passes voltage function tests
37903e6
valentinsulzer pushed a commit that referenced this issue Jul 25, 2019
@Scottmar93
#492 passes unit tests but not integration tests
afdbe91
@valentinsulzer valentinsulzer self-assigned this Nov 14, 2019
valentinsulzer added a commit that referenced this issue Nov 14, 2019
@valentinsulzer
#492 reformat constant current to be a submodel
c16b916
valentinsulzer added a commit that referenced this issue Nov 14, 2019
@valentinsulzer
#492 merge master
8ff9640
valentinsulzer added a commit that referenced this issue Nov 14, 2019
@valentinsulzer
#492 fix bugs
ab9d5a6
valentinsulzer added a commit that referenced this issue Nov 14, 2019
@valentinsulzer
#492 constant voltage works for DFN
ee030ee
valentinsulzer added a commit that referenced this issue Nov 14, 2019
@valentinsulzer
#492 get potentiostatic working for 1D lithium-ion
049960d
valentinsulzer added a commit that referenced this issue Nov 14, 2019
@valentinsulzer
#492 get working for 3d (in theory)
7ee11c5
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#492 reorganise and add power
c2b7e38
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#492 add charging strategies example
8561598
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#492 add docs and unit tests
e968272
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#492 merge master
d63f838
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#492 add integration test - wrong current
db3ebbb
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#492 trying to get charging strategies working
a24543c
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 more reformatting, need to figure out currents still
e14811d
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 get direct voltage model working
e678d23
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 add discharge capacity as a variable with ODE
172f1ec
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 updating current function and C-rate
a3b302e
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 change solver times in examples
120178b
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 fixing some tests
4238ad1
@valentinsulzer valentinsulzer mentioned this issue Nov 30, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 30, 2019
@valentinsulzer
#492 fixing more tests and examples
194c707
valentinsulzer added a commit that referenced this issue Dec 3, 2019
@valentinsulzer
#492 fix easy tests
2cd3f44
valentinsulzer added a commit that referenced this issue Dec 3, 2019
@valentinsulzer
#492 debugging composite models
6e723a2
valentinsulzer added a commit that referenced this issue Dec 3, 2019
@valentinsulzer
#492 flake8
b6393ee
valentinsulzer added a commit that referenced this issue Dec 3, 2019
@valentinsulzer
#492 remove debug
8710f5e
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#492 remove direct voltage control, too much effort
f113293
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#492 clean up setting external variables for potentials
5f3bd18
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#492 fix unit tests
7d156dd
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#492 fixing integration tests and examples
e638b1b
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#492 tests and coverage
7597712
valentinsulzer added a commit that referenced this issue Dec 6, 2019
@valentinsulzer
#492 merge master
2fd4883
valentinsulzer added a commit that referenced this issue Dec 6, 2019
@valentinsulzer
#492 don't print casadi warnings in test
55c5e88
valentinsulzer added a commit that referenced this issue Dec 6, 2019
@valentinsulzer
#492 fix composite
7eb60ec
valentinsulzer added a commit that referenced this issue Dec 7, 2019
@valentinsulzer
#492 coverage for parameter values
c13d8b9
valentinsulzer added a commit that referenced this issue Dec 7, 2019
@valentinsulzer
#492 change to casadi solver for broken test
fed0bbb
valentinsulzer added a commit that referenced this issue Dec 13, 2019
@valentinsulzer
#492 merge master
b3e0151
valentinsulzer added a commit that referenced this issue Dec 13, 2019
@valentinsulzer
#492 rob comments
84867e1
valentinsulzer added a commit that referenced this issue Dec 14, 2019
@valentinsulzer
#492 merge master
cee062c
valentinsulzer added a commit that referenced this issue Dec 14, 2019
@valentinsulzer
#492 fix test
b54eb0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 492 potentiostatic pybamm-team/PyBaMM
2 participants
@valentinsulzer @rtimms