Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Phases (composite electrode) + PSD (particle size distribution) Model Option Compatibility #4056

Closed
mleot opened this issue Apr 30, 2024 · 1 comment
Labels

Comments

@mleot
Copy link
Contributor

mleot commented Apr 30, 2024

Description

This issue is simply asking for the ability to specify multiple phases in addition to a particle size distribution. Since there are error raising statements already in place here, I am considering this to be a feature addition and not a bug.

Motivation

Simply put, if there is no fundamental blocker preventing these model options from being used together, it would be nice to be able to specify both of these physics at once.

Possible Implementation

I think the first step is to just remove the error raising statement linked above in the description, and see what other errors, if any, arise. If it does require some more careful refactoring, then I think further discussion should be had around the next steps.

Additional context

No response

@mleot mleot added the feature label Apr 30, 2024
rtimms added a commit that referenced this issue Dec 19, 2024
rtimms added a commit that referenced this issue Dec 20, 2024
rtimms added a commit that referenced this issue Dec 20, 2024
@rtimms
Copy link
Contributor

rtimms commented Dec 30, 2024

Fixed by #4687

@rtimms rtimms closed this as completed Dec 30, 2024
rtimms added a commit that referenced this issue Dec 30, 2024
rtimms added a commit that referenced this issue Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants