Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a pybamm.ParameterValues from a BPX file #2376

Closed
martinjrobins opened this issue Oct 18, 2022 · 0 comments · Fixed by #2555
Closed

Create a pybamm.ParameterValues from a BPX file #2376

martinjrobins opened this issue Oct 18, 2022 · 0 comments · Fixed by #2555
Labels
feature

Comments

@martinjrobins
Copy link
Contributor

Description

https://github.com/pybamm-team/BPX defines a battery model parameter exchange format. This issue proposes a function in pybamm that will take a BPX file and return a pybamm.ParameterValues object that can be used to simulate from a DFN model

Motivation

To allow a BPX=>pybamm workflow

Possible Implementation

No response

Additional context

No response
martinjrobins added a commit that referenced this issue Oct 18, 2022
@martinjrobins
#2376 added a draft bpx -> pybamm converter
326d5cf
martinjrobins added a commit that referenced this issue Oct 18, 2022
@martinjrobins
#2376 add a bpx test
7feb92e
martinjrobins added a commit that referenced this issue Oct 18, 2022
@martinjrobins
#2376, added bpx conversions and some defaults, remove events in simu…
f36845d 
…lation, still problems with diffusivity
martinjrobins added a commit that referenced this issue Oct 25, 2022
@martinjrobins
#2376 match test to parameterised battery, add diffusivity and conduc…
4e8d34c 
…tivity equatinos
rtimms added a commit that referenced this issue Oct 27, 2022
@rtimms
#2376 debug function parameters
b38f3a4
rtimms added a commit that referenced this issue Nov 1, 2022
@rtimms
#2376 debug function parameters
47f8ad2
martinjrobins added a commit that referenced this issue Nov 9, 2022
@martinjrobins
#2376 remove some print stmts
da98f9a
rtimms added a commit that referenced this issue Nov 22, 2022
@rtimms
#2376 update to new schema
d149c7a
rtimms added a commit that referenced this issue Nov 25, 2022
@rtimms
#2376 add sto windows
32a7a3f
rtimms added a commit that referenced this issue Dec 1, 2022
@rtimms
#2376 entropic change
ee1944d
rtimms added a commit that referenced this issue Dec 2, 2022
@rtimms
#2376 debug init events
bf0d676
rtimms added a commit that referenced this issue Dec 2, 2022
@rtimms
#2376 debug init events
16902f2
rtimms added a commit that referenced this issue Dec 14, 2022
@rtimms
#2376 update bpx version
80e26e1
@rtimms rtimms mentioned this issue Dec 14, 2022
Merged
8 tasks
rtimms added a commit that referenced this issue Dec 14, 2022
@rtimms
#2376 changelog
6528ea9
rtimms added a commit that referenced this issue Dec 14, 2022
@rtimms
#2376 changelog
64c01e9
rtimms added a commit that referenced this issue Dec 14, 2022
@rtimms
#2376 update test
e5874bb
rtimms added a commit that referenced this issue Dec 15, 2022
@rtimms
#2376 coverage
3166814
rtimms added a commit that referenced this issue Dec 21, 2022
@rtimms
#2376 make private
dcd39ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I2376 bpx pybamm-team/PyBaMM
1 participant
@martinjrobins