Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning when converting pchip interpolants to casadi #1481

Closed
rtimms opened this issue May 11, 2021 · 0 comments · Fixed by #1791
Closed

Raise warning when converting pchip interpolants to casadi #1481

rtimms opened this issue May 11, 2021 · 0 comments · Fixed by #1791
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours

Comments

@rtimms
Copy link
Contributor

rtimms commented May 11, 2021

When a pybamm.Interpolant object is created you can set the interpolator to "linear", "pchip" or "cubic spline" (default). When this node gets converted to casadi, the converted interpolator is always a spline. We should raise a warning if an Interpolant using "linear" or "pchip" gets converted to casadi's interpolant so that users know it is switching to a spline.

@rtimms rtimms added the difficulty: easy A good issue for someone new. Can be done in a few hours label May 28, 2021
rtimms added a commit that referenced this issue Nov 9, 2021
rtimms added a commit that referenced this issue Nov 10, 2021
rtimms added a commit that referenced this issue Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant