Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better plot styles #1413

Closed
valentinsulzer opened this issue Mar 4, 2021 · 0 comments · Fixed by #1419
Closed

Better plot styles #1413

valentinsulzer opened this issue Mar 4, 2021 · 0 comments · Fixed by #1419

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Mar 4, 2021 •
edited
Loading

matplotlib provides customizations via style sheets and rcparams. https://matplotlib.org/stable/tutorials/introductory/customizing.html

We should rewrite the plotting functions in a way that the user gets full control via matplotlib (i.e. nothing gets hardcoded in the plotting functions).
We can also provide some defaults that we are happy with
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 switch to style file
0b46925
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 add tests
8bf954f
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 add example notebook
df4c398
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 n_rows option
4eae4b4
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 docs
b7c102d
@valentinsulzer valentinsulzer mentioned this issue Mar 5, 2021
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 changelog and attempted test fix
0f155f6
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 skip aligning figure if the backend is Template (example tests)
07a4763
valentinsulzer added a commit that referenced this issue Mar 5, 2021
@valentinsulzer
#1413 fix pybamm install command
2fc25bf
valentinsulzer added a commit that referenced this issue Mar 6, 2021
@valentinsulzer
#1413 fix install command again
d471dc4
valentinsulzer added a commit that referenced this issue Mar 6, 2021
@valentinsulzer
#1413 install SciencePlots for examples
983ecd5
valentinsulzer added a commit that referenced this issue Mar 7, 2021
@valentinsulzer
#1413 don't use SciencePlots in example
6deea06
valentinsulzer added a commit that referenced this issue Mar 8, 2021
@valentinsulzer
#1413 coverage
36f9c09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1413 plotting pybamm-team/PyBaMM
1 participant
@valentinsulzer