Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage report not being run #1191

Closed
brosaplanella opened this issue Oct 16, 2020 · 0 comments · Fixed by #1192
Closed

Coverage report not being run #1191

brosaplanella opened this issue Oct 16, 2020 · 0 comments · Fixed by #1192

Comments

@brosaplanella
Copy link
Member

Describe the bug
The coverage report is not run in the automatic tests.

To Reproduce
Check any of the open PRs
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1191 fixed typo in workflow
f8e2e9a
@brosaplanella brosaplanella mentioned this issue Oct 16, 2020
Merged
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1191 added numpy to tox deps
208a6f0
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1191 set coverage skip_install to false
178d07a
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1191 tox -e coverage runs codecov too
fd4eb13
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 19, 2020
@brosaplanella
pybamm-team#1191 try exporting coverage to xml
6841122
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 19, 2020
@brosaplanella
pybamm-team#1191 fix bug
c60763f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 19, 2020
@brosaplanella
pybamm-team#1191 Thibault's comment
030c4b9
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 19, 2020
@brosaplanella
pybamm-team#1191 install scikits in coverage
4065886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix coverage brosaplanella/PyBaMM
1 participant
@brosaplanella