-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically compute parameters based on geometry #1115
Comments
rtimms
added a commit
that referenced
this issue
Jul 29, 2020
rtimms
added a commit
that referenced
this issue
Aug 4, 2020
rtimms
added a commit
that referenced
this issue
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Change parameter files to automatically compute surface area per unit volume based on particle shape, e.g.
a = 3*eps/R
for spheres. The plan is to make things likestandard_parameters_lithium_ion.py
classes so they can take options. For now I'll just compute surface area per unit volume, but there may be other things we want to automate based on options (e.g. cell volume based on pouch, cylinder etc.). Any suggestions welcome.The text was updated successfully, but these errors were encountered: