Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically compute parameters based on geometry #1115

Closed
rtimms opened this issue Jul 27, 2020 · 0 comments · Fixed by #1120
Closed

automatically compute parameters based on geometry #1115

rtimms opened this issue Jul 27, 2020 · 0 comments · Fixed by #1120
Assignees

Comments

@rtimms
Copy link
Contributor

rtimms commented Jul 27, 2020

Change parameter files to automatically compute surface area per unit volume based on particle shape, e.g. a = 3*eps/R for spheres. The plan is to make things like standard_parameters_lithium_ion.py classes so they can take options. For now I'll just compute surface area per unit volume, but there may be other things we want to automate based on options (e.g. cell volume based on pouch, cylinder etc.). Any suggestions welcome.

@rtimms rtimms self-assigned this Jul 27, 2020
rtimms added a commit that referenced this issue Jul 28, 2020
rtimms added a commit that referenced this issue Jul 28, 2020
rtimms added a commit that referenced this issue Jul 31, 2020
rtimms added a commit that referenced this issue Jul 31, 2020
rtimms added a commit that referenced this issue Jul 31, 2020
rtimms added a commit that referenced this issue Jul 31, 2020
@rtimms rtimms mentioned this issue Jul 31, 2020
8 tasks
rtimms added a commit that referenced this issue Aug 4, 2020
rtimms added a commit that referenced this issue Aug 4, 2020
rtimms added a commit that referenced this issue Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant