Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support additional numpy function in convert to casadi #1066

Closed
martinjrobins opened this issue Jun 22, 2020 · 0 comments · Fixed by #1067
Closed

support additional numpy function in convert to casadi #1066

martinjrobins opened this issue Jun 22, 2020 · 0 comments · Fixed by #1067
Assignees
@martinjrobins
Labels
bug Something isn't working

Comments

@martinjrobins
Copy link
Contributor

Describe the bug

CasadiConverter fails on expression trees with the following numpy function: np.exp, np.sin, np.cos, np.sqrt

To Reproduce

create an expression tree with the above functions

Expected behaviour

CasadiConverter should be able to convert the tree

Solution is the simply add these to line ~99 of convert_to_casadi.py
@martinjrobins martinjrobins self-assigned this Jun 22, 2020
@martinjrobins martinjrobins added the bug Something isn't working label Jun 22, 2020
martinjrobins added a commit that referenced this issue Jun 22, 2020
@martinjrobins
#1066 add numpy function sqrt, sin, cos and exp to convert_to_casadi
feb1e1e
@martinjrobins martinjrobins mentioned this issue Jun 22, 2020
Merged
6 tasks
martinjrobins added a commit that referenced this issue Jun 22, 2020
@martinjrobins
#1066 update changelog
eb32c9b
martinjrobins added a commit that referenced this issue Jun 22, 2020
@martinjrobins
#1066 get rid of print statement
c235bde
martinjrobins added a commit that referenced this issue Jun 22, 2020
@martinjrobins
#1066 add hyperbolic functions
afefa83
valentinsulzer added a commit that referenced this issue Jun 22, 2020
@valentinsulzer
#1066 fix deprecations
b25b434
valentinsulzer added a commit that referenced this issue Jun 22, 2020
@valentinsulzer
#1066 use nans when evaluating for shape to avoid runtime warnings
bc7745a
martinjrobins added a commit that referenced this issue Jun 23, 2020
@martinjrobins
#1066 add test for numpy special functions
67f0fc1
valentinsulzer added a commit that referenced this issue Jun 23, 2020
@valentinsulzer
Merge pull request #1067 from pybamm-team/issue-1066-additional-casad…
6c7a06e 
…i-funcitons

#1066 add numpy function sqrt, sin, cos and exp to convert_to_casadi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinjrobins martinjrobins

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1066 add numpy function sqrt, sin, cos and exp to convert_to_casadi pybamm-team/PyBaMM
1 participant
@martinjrobins