Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend parameters-cli for drive cycles #1056

Closed
brosaplanella opened this issue Jun 15, 2020 · 0 comments · Fixed by #1116
Closed

Extend parameters-cli for drive cycles #1056

brosaplanella opened this issue Jun 15, 2020 · 0 comments · Fixed by #1116

Comments

@brosaplanella
Copy link
Member

Summary
Extend the capabilities of parameters-cli (or create a new function) so the drive cycle folder can be copied to a local directory and new drive cycles added locally.
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 28, 2020
@brosaplanella
pybamm-team#1056 added examples on how to pass custom drive cycle
c57f1bd
@brosaplanella brosaplanella mentioned this issue Jul 28, 2020
Merged
5 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 28, 2020
@brosaplanella
pybamm-team#1056 fixed drive cycle path
bf2f41a
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 29, 2020
@brosaplanella
pybamm-team#1056 Tino's comments
9d818a9
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 29, 2020
@brosaplanella
pybamm-team#1056 removed commented line
bafb33c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 29, 2020
@brosaplanella
pybamm-team#1056 deprecated drive cycle from data
26b7136
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 29, 2020
@brosaplanella
pybamm-team#1056 fixed example script
84231f5
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 30, 2020
@brosaplanella
pybamm-team#1056 improve coverage
0586141
valentinsulzer added a commit that referenced this issue Jul 30, 2020
@valentinsulzer
Merge pull request #1116 from ferranbrosa/issue-1056-custom-drive-cycle
07d250d 
#1056 added examples on how to pass custom drive cycle
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jul 30, 2020
@brosaplanella
pybamm-team#1056 needs further debugging
39166c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1056 added examples on how to pass custom drive cycle brosaplanella/PyBaMM
1 participant
@brosaplanella