Skip to content

Commit

Permalink
Fix style issues: remove duplicate function, fix indentation, and rem…
Browse files Browse the repository at this point in the history
…ove unused variable
  • Loading branch information
mohammedasher committed Oct 15, 2024
1 parent 029cdee commit b9a02bb
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 34 deletions.
33 changes: 0 additions & 33 deletions src/pybamm/input/parameters/lithium_ion/Chen2020_composite.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,39 +347,6 @@ def nmc_LGM50_ocp_Chen2020(sto):
return u_eq


def nmc_LGM50_ocp_Chen2020(sto):
"""
LG M50 NMC open-circuit potential as a function of stoichiometry, fit taken
from [1].
References
----------
.. [1] Chang-Hui Chen, Ferran Brosa Planella, Kieran O’Regan, Dominika Gastol, W.
Dhammika Widanage, and Emma Kendrick. "Development of Experimental Techniques for
Parameterization of Multi-scale Lithium-ion Battery Models." Journal of the
Electrochemical Society 167 (2020): 080534.
Parameters
----------
sto: :class:`pybamm.Symbol`
Electrode stoichiometry
Returns
-------
:class:`pybamm.Symbol`
Open-circuit potential
"""

u_eq = (
-0.8090 * sto
+ 4.4875
- 0.0428 * np.tanh(18.5138 * (sto - 0.5542))
- 17.7326 * np.tanh(15.7890 * (sto - 0.3117))
+ 17.5842 * np.tanh(15.9308 * (sto - 0.3120))
)

return u_eq


def nmc_LGM50_electrolyte_exchange_current_density_Chen2020(c_e, c_s_surf, c_s_max, T):
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,7 @@ def __init__(self, extra_options):
options["stress-induced diffusion"] == "true"
#and options["particle mechanics"] == "none"
):
pass
# raise pybamm.OptionError(
# "cannot have stress-induced diffusion without a particle "
# "mechanics model"
Expand Down
1 change: 0 additions & 1 deletion src/pybamm/models/submodels/particle/base_particle.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def __init__(self, param, domain, options, phase="primary"):

def _get_effective_diffusivity(self, c, T, current):
domain, Domain = self.domain_Domain
domain_param = self.domain_param
phase_param = self.phase_param
domain_options = getattr(self.options, domain)

Expand Down

0 comments on commit b9a02bb

Please sign in to comment.