Sei composite multiparticle (#4693)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Features
 
+- Enabled using SEI models with particle size distributions. ([#4693](https://github.com/pybamm-team/PyBaMM/pull/4693))
 - Added symbolic mesh which allows for using InputParameters for geometric parameters ([#4665](https://github.com/pybamm-team/PyBaMM/pull/4665))
 - Enhanced the `search` method to accept multiple search terms in the form of a string or a list. ([#4650](https://github.com/pybamm-team/PyBaMM/pull/4650))
 - Made composite electrode model compatible with particle size distribution ([#4687](https://github.com/pybamm-team/PyBaMM/pull/4687))

src/pybamm/models/full_battery_models/base_battery_model.py

@@ -526,10 +526,15 @@ def __init__(self, extra_options):
         # Options not yet compatible with particle-size distributions
         if options["particle size"] == "distribution":
             if options["lithium plating porosity change"] != "false":
-                raise NotImplementedError(
+                raise pybamm.OptionError(
                     "Lithium plating porosity change not yet supported for particle-size"
                     " distributions."
                 )
+            if options["SEI porosity change"] == "true":
+                raise NotImplementedError(
+                    "SEI porosity change submodels do not yet support particle-size "
+                    "distributions."
+                )
             if options["heat of mixing"] != "false":
                 raise NotImplementedError(
                     "Heat of mixing submodels do not yet support particle-size "
@@ -550,10 +555,6 @@ def __init__(self, extra_options):
                     "Particle shape must be 'spherical' for particle-size distribution"
                     " submodels."
                 )
-            if options["SEI"] != "none":
-                raise NotImplementedError(
-                    "SEI submodels do not yet support particle-size distributions."
-                )
             if options["stress-induced diffusion"] == "true":
                 raise NotImplementedError(
                     "stress-induced diffusion cannot yet be included in "

src/pybamm/models/submodels/interface/kinetics/base_kinetics.py

@@ -151,6 +151,10 @@ def get_coupled_variables(self, variables):
             j_tot.print_name = "j_tot"
 
             eta_sei = -j_tot * L_sei * R_sei
+            if self.size_distribution and eta_r.domains["secondary"] != [
+                f"{domain} electrode"
+            ]:
+                eta_sei = pybamm.x_average(eta_sei)
         else:
             eta_sei = pybamm.Scalar(0)
         eta_r += eta_sei

tests/unit/test_models/test_full_battery_models/test_base_battery_model.py

@@ -313,6 +313,13 @@ def test_options(self):
                     "plating porosity change"
                 }
             )
+        with pytest.raises(pybamm.OptionError, match="distributions"):
+            pybamm.BaseBatteryModel(
+                {
+                    "particle size": "distribution",
+                    "lithium plating porosity change": "true",
+                }
+            )
 
         # contact resistance
         with pytest.raises(pybamm.OptionError, match="contact resistance"):

tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_mpm.py

@@ -98,7 +98,7 @@ def test_reversible_plating_with_porosity_not_implemented(self):
             "lithium plating": "reversible",
             "lithium plating porosity change": "true",
         }
-        with pytest.raises(NotImplementedError):
+        with pytest.raises(pybamm.OptionError, match="distributions"):
             pybamm.lithium_ion.MPM(options)
 
     def test_stress_induced_diffusion_not_implemented(self):
@@ -159,25 +159,25 @@ def external_circuit_function(variables):
 
 
 class TestMPMWithSEI:
-    def test_reaction_limited_not_implemented(self):
+    def test_reaction_limited(self):
         options = {"SEI": "reaction limited"}
-        with pytest.raises(NotImplementedError):
-            pybamm.lithium_ion.MPM(options)
+        model = pybamm.lithium_ion.MPM(options)
+        model.check_well_posedness()
 
-    def test_solvent_diffusion_limited_not_implemented(self):
+    def test_solvent_diffusion_limited(self):
         options = {"SEI": "solvent-diffusion limited"}
-        with pytest.raises(NotImplementedError):
-            pybamm.lithium_ion.MPM(options)
+        model = pybamm.lithium_ion.MPM(options)
+        model.check_well_posedness()
 
-    def test_electron_migration_limited_not_implemented(self):
+    def test_electron_migration_limited(self):
         options = {"SEI": "electron-migration limited"}
-        with pytest.raises(NotImplementedError):
-            pybamm.lithium_ion.MPM(options)
+        model = pybamm.lithium_ion.MPM(options)
+        model.check_well_posedness()
 
-    def test_interstitial_diffusion_limited_not_implemented(self):
+    def test_interstitial_diffusion_limited(self):
         options = {"SEI": "interstitial-diffusion limited"}
-        with pytest.raises(NotImplementedError):
-            pybamm.lithium_ion.MPM(options)
+        model = pybamm.lithium_ion.MPM(options)
+        model.check_well_posedness()
 
     def test_ec_reaction_limited_not_implemented(self):
         options = {