Skip to content

Commit

Permalink
#880 fixed tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Scottmar93 committed Mar 30, 2020
1 parent 053ab3d commit 7e66610
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
7 changes: 4 additions & 3 deletions pybamm/parameters/standard_parameters_lead_acid.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,14 @@


def t_plus(c_e):
"Dimensionless transference number (i.e. c_e is dimensional)"
return pybamm.FunctionParameter("Cation transference number", c_e * c_e_typ)
"Dimensionless transference number (i.e. c_e is dimensionless)"
inputs = {"Electrolyte concentration [mol.m-3]": c_e * c_e_typ}
return pybamm.FunctionParameter("Cation transference number", inputs)


def D_e_dimensional(c_e, T):
"Dimensional diffusivity in electrolyte"
inputs = {"Electrolyte concentration [mol.m-3": c_e}
inputs = {"Electrolyte concentration [mol.m-3]": c_e}
return pybamm.FunctionParameter("Electrolyte diffusivity [m2.s-1]", inputs)


Expand Down
7 changes: 5 additions & 2 deletions pybamm/parameters/standard_parameters_lithium_ion.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,14 @@ def U_p_dimensional(sto, T):


def t_plus(c_e):
return pybamm.FunctionParameter("Cation transference number", c_e)
"Dimensionless transference number (i.e. c_e is dimensionless)"
inputs = {"Electrolyte concentration [mol.m-3]": c_e * c_e_typ}
return pybamm.FunctionParameter("Cation transference number", inputs)


def one_plus_dlnf_dlnc(c_e):
return pybamm.FunctionParameter("1 + dlnf/dlnc", c_e)
inputs = {"Electrolyte concentration [mol.m-3]": c_e * c_e_typ}
return pybamm.FunctionParameter("1 + dlnf/dlnc", inputs)


beta_surf = pybamm.Scalar(0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
import unittest


pybamm.set_logging_level("DEBUG")
pybamm.settings.debug_mode = True


class TestSPMe(unittest.TestCase):
def test_basic_processing(self):
options = {"thermal": "isothermal"}
Expand Down

0 comments on commit 7e66610

Please sign in to comment.