Skip to content

Commit

Permalink
Merge pull request #1097 from pybamm-team/issue-1096-sei-bug
Browse files Browse the repository at this point in the history
#1096 fix sei typo
  • Loading branch information
valentinsulzer authored Jul 1, 2020
2 parents 33e695e + e1d956d commit 56c0383
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ This release enables the use of [Google Colab](https://colab.research.google.com

## Bug fixes

- Fixed a bug in `InterstitialDiffusionLimited` ([#1097](https://github.com/pybamm-team/PyBaMM/pull/1097))
- Fixed `Simulation` to keep different copies of the model so that parameters can be changed between simulations ([#1090](https://github.com/pybamm-team/PyBaMM/pull/1090))
- Fixed `model.new_copy()` to keep custom submodels ([#1090](https://github.com/pybamm-team/PyBaMM/pull/1090))
- 2D processed variables can now be evaluated at the domain boundaries ([#1088](https://github.com/pybamm-team/PyBaMM/pull/1088))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@ def get_coupled_variables(self, variables):
"Inner " + self.domain.lower() + " electrode sei thickness"
]
phi_s_n = variables[self.domain + " electrode potential"]
phi_e_n = variables[self.domain + " electrolyte potential"]

if self.domain == "Negative":
C_sei = self.param.C_sei_inter_n

j_sei = -pybamm.exp(-phi_s_n) / (C_sei * L_sei_inner)
j_sei = -pybamm.exp(-(phi_s_n - phi_e_n)) / (C_sei * L_sei_inner)

alpha = 0.5
j_inner = alpha * j_sei
Expand Down

0 comments on commit 56c0383

Please sign in to comment.