#880 fix tino comment

pybamm-team · Mar 30, 2020 · 2a4f792 · 2a4f792
1 parent 0dcfd4a
commit 2a4f792
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/pybamm/expression_tree/parameter.py b/pybamm/expression_tree/parameter.py
@@ -84,6 +84,9 @@ def __init__(
 
     @property
     def input_names(self):
+        return self._input_names
+
+    def print_input_names(self):
         if self._input_names:
             for inp in self._input_names:
                 print(inp)

diff --git a/pybamm/models/base_model.py b/pybamm/models/base_model.py
@@ -645,7 +645,7 @@ def info(self, symbol_name):
         if isinstance(symbol, pybamm.FunctionParameter):
             print("")
             print("Inputs:")
-            symbol.input_names
+            symbol.print_input_names()
 
         print(div)
 

diff --git a/tests/unit/test_expression_tree/test_parameter.py b/tests/unit/test_expression_tree/test_parameter.py
@@ -43,12 +43,12 @@ def test_copy(self):
         func = pybamm.FunctionParameter("func", {"2a": 2 * a})
 
         new_func = func.new_copy()
-        self.assertEqual(func._input_names, new_func._input_names)
+        self.assertEqual(func.input_names, new_func.input_names)
 
     def test_print_input_names(self):
         var = pybamm.Variable("var")
         func = pybamm.FunctionParameter("a", {"var": var})
-        func.input_names
+        func.print_input_names()
 
     def test_get_children_domains(self):
         var = pybamm.Variable("var", domain=["negative electrode"])
@@ -64,7 +64,7 @@ def test_set_input_names(self):
         new_input_names = ["first", "second"]
         func.input_names = new_input_names
 
-        self.assertEqual(func._input_names, new_input_names)
+        self.assertEqual(func.input_names, new_input_names)
 
         with self.assertRaises(TypeError):
             new_input_names = {"wrong": "input type"}