#858 improve coverage

pybamm-team · Mar 16, 2020 · 0c5270e · 0c5270e
1 parent 345be6a
commit 0c5270e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/tests/unit/test_expression_tree/test_operations/test_jac.py b/tests/unit/test_expression_tree/test_operations/test_jac.py
@@ -105,6 +105,14 @@ def test_nonlinear(self):
         dfunc_dy = func.jac(y).evaluate(y=y0)
         np.testing.assert_array_equal(jacobian, dfunc_dy.toarray())
 
+    def test_multislice_raises(self):
+        y1 = pybamm.StateVector(slice(0, 4), slice(7, 8))
+        y2 = pybamm.StateVector(slice(4, 7))
+        with self.assertRaises(NotImplementedError):
+            y1.jac(y1)
+        with self.assertRaises(NotImplementedError):
+            y2.jac(y1)
+
     def test_linear_ydot(self):
         y = pybamm.StateVector(slice(0, 4))
         y_dot = pybamm.StateVectorDot(slice(0, 4))

diff --git a/tests/unit/test_expression_tree/test_symbolic_diff.py b/tests/unit/test_expression_tree/test_symbolic_diff.py
@@ -60,6 +60,12 @@ def test_diff_zero(self):
         self.assertEqual(func.diff(b).id, pybamm.Scalar(0).id)
         self.assertNotEqual(func.diff(a).id, pybamm.Scalar(0).id)
 
+    def test_diff_state_vector_dot(self):
+        a = pybamm.StateVectorDot(slice(0, 1))
+        b = pybamm.StateVector(slice(1, 2))
+        self.assertEqual(a.diff(a).id, pybamm.Scalar(1).id)
+        self.assertEqual(a.diff(b).id, pybamm.Scalar(0).id)
+
     def test_diff_heaviside(self):
         a = pybamm.Scalar(1)
         b = pybamm.StateVector(slice(0, 1))