#1082 add particle events, should never be triggered?

pybamm-team · Mar 27, 2021 · 05c091d · 05c091d
1 parent ddc9cb3
commit 05c091d
Showing 1 changed file with 18 additions and 19 deletions.
diff --git a/pybamm/models/submodels/particle/base_particle.py b/pybamm/models/submodels/particle/base_particle.py
@@ -144,22 +144,21 @@ def _get_standard_flux_variables(self, N_s, N_s_xav):
 
         return variables
 
-    # def set_events(self, variables):
-    #     c_s_surf = variables[self.domain + " particle surface concentration"]
-    #     tol = 1e-4
-
-    #     self.events.append(
-    #         pybamm.Event(
-    #             "Minumum " + self.domain.lower() + " particle surface concentration",
-    #             pybamm.min(c_s_surf) - tol,
-    #             pybamm.EventType.TERMINATION,
-    #         )
-    #     )
-
-    #     self.events.append(
-    #         pybamm.Event(
-    #             "Maximum " + self.domain.lower() + " particle surface concentration",
-    #             (1 - tol) - pybamm.max(c_s_surf),
-    #             pybamm.EventType.TERMINATION,
-    #         )
-    #     )
+    def set_events(self, variables):
+        c_s_surf = variables[self.domain + " particle surface concentration"]
+
+        self.events.append(
+            pybamm.Event(
+                "Minumum " + self.domain.lower() + " particle surface concentration",
+                pybamm.min(c_s_surf),
+                pybamm.EventType.TERMINATION,
+            )
+        )
+
+        self.events.append(
+            pybamm.Event(
+                "Maximum " + self.domain.lower() + " particle surface concentration",
+                pybamm.max(c_s_surf),
+                pybamm.EventType.TERMINATION,
+            )
+        )