Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using a pruner in the Optimizer #52

Open
arxaqapi opened this issue Aug 7, 2024 · 1 comment
Open

Error when using a pruner in the Optimizer #52

arxaqapi opened this issue Aug 7, 2024 · 1 comment

Comments

@arxaqapi
Copy link
Contributor

arxaqapi commented Aug 7, 2024

The following error is encountered Trial.should_prune() takes 1 positional argument but 2 were given when running an Optimizer instance created using a pruner like seen below:

optimizer = Optimizer(pipeline, sampler="TPESampler", pruner="SuccessiveHalvingPruner")

Here is a MRE to display the error:
MRE_pyannote_pipeline_optuna.ipynb

The optuna version used in the MRE is optuna==3.6.1

arxaqapi added a commit to arxaqapi/pyannote-pipeline that referenced this issue Aug 7, 2024
@FrenchKrab
Copy link

FrenchKrab commented Aug 22, 2024

I think the changes in your repository fully fix this issue, you should submit a pull request !
EDIT: nevermind i'm blind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants