Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.lab extension supported #82

Merged
merged 16 commits into from
Jun 2, 2022
Merged

.lab extension supported #82

merged 16 commits into from
Jun 2, 2022

Conversation

FrancescoBonzi
Copy link
Contributor

No description provided.

hbredin
hbredin requested changes Mar 13, 2022
View reviewed changes
Copy link
Member

@hbredin hbredin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

However, LABLoader currently misses the placeholder handling logic.
See my comments in the code

pyannote/database/util.py Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
@FrancescoBonzi FrancescoBonzi requested a review from hbredin March 25, 2022 16:51
hbredin
hbredin requested changes Jun 2, 2022
View reviewed changes
Copy link
Member

@hbredin hbredin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me of this PR which I had completely forgotten.

A few simplifying changes and we are good to go. See comments in code.

Can you also please remove both .DS_Store files?

pyannote/database/loader.py Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
pyannote/database/loader.py Outdated Show resolved Hide resolved
pyannote/database/util.py Outdated Show resolved Hide resolved
hbredin
hbredin reviewed Jun 2, 2022
View reviewed changes
pyannote/database/loader.py Outdated Show resolved Hide resolved
hbredin
hbredin reviewed Jun 2, 2022
View reviewed changes
pyannote/database/loader.py Outdated Show resolved Hide resolved
hbredin
hbredin reviewed Jun 2, 2022
View reviewed changes
pyannote/database/loader.py Outdated Show resolved Hide resolved
@hbredin hbredin merged commit 11d8dcb into pyannote:develop Jun 2, 2022
@hbredin
Copy link
Member

hbredin commented Jun 2, 2022

Thanks 🎉

@FrancescoBonzi
Copy link
Contributor Author

Thank you for sharing this awesome tool! Happy to contribute 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbredin hbredin hbredin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrancescoBonzi @hbredin