Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributor and review data #238

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Update contributor and review data #238

merged 2 commits into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@@ -4638,7 +4640,7 @@
packages_reviewed:
location:
email:
- name:
- name: Beryl Kanali
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pllim i have a test run that we can use here now !! it captured the changes that you just made to the names!! yay!!

organization:
date_added: '2024-03-09'
date_added: '2024-11-22'
Copy link
Member

@lwasser lwasser Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never be updated as it's the date a contributor was added to this file. This is a bug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops looks like I added conflicting info back in pyOpenSci/pyopensci.github.io#530 . I didn't realize this file exists in multiple places. Did I change it in the wrong repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pllim you did everything right. I made a "test" copy of the workflow over here so we can test things every time we make changes to pyosmeta. So please consider this pr a end-to-end test in the pyosmeta not the final website file!!

The goal is to avoid troubleshooting pyosmeta in the website repo and rather to catch things PRIOR to a new release. You corrected things in the right spot!! This date update specifically is i think a bug in our workflow. i don't recall you changing the dates anywhere!!
Does that make sense?

btw - Name was actually in our issue template so i cleaned that up too! i'm finding lots of small bugs thanks to you.

@lwasser
Copy link
Member

lwasser commented Nov 22, 2024

i'll rename the pr title end-to-end tests so it's clear that this is a test run, not a real contributor update.

@@ -51,7 +51,13 @@
github_username: matteobachetti
all_current_maintainers:
- name: Daniela Huppenkothen
github_username: dhuppenkothen mgullik jdswinbank matteolucchini1
github_username: dhuppenkothen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, maintainers are now populating correctly. We just need a small reminder in the issue to add commas for parsing. If this happens again, we can consider adding more logic to the code it will just get complicated, given the many variations that users could provide.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lwasser
Copy link
Member

lwasser commented Dec 13, 2024

pre-commit.ci autofix

for more information, see https://pre-commit.ci
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (e389269) to head (7489b8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files          10       10           
  Lines         671      671           
  Branches       82       82           
=======================================
  Hits          497      497           
  Misses        166      166           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwasser lwasser merged commit b6179f3 into main Dec 13, 2024
5 checks passed
@lwasser lwasser deleted the contribs branch December 13, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants