Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: advisory_council should default to false #200

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Aug 1, 2024

This is a small fix to ensure that emeritus advisory and advisory roles:

  1. default to false
  2. always have a bool value which should default to false
  3. should not be changed by the code if the value in the data is true (i think this was just a tiny bug that i found).

@lwasser lwasser merged commit 1d92f90 into main Aug 1, 2024
2 checks passed
@lwasser lwasser deleted the fix-advisory-bool branch August 1, 2024 16:18
@lwasser lwasser mentioned this pull request Aug 1, 2024
"emeritus_editor",
"editorial_board",
mode="before",
always=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser It looks like this field is causing an issue with CI. What is the purpose of always?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot @willingc i merged this too quickly. in the PR the tests had passed (well i thought they had maybe they hadn't!) I suspect always=true was made up by LLMS. i often use chatgpt to proof my code / format etc. and it suggested that addition and i used it without researching. this is my mistake. i should know better than to listen to a llm!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i looked more closely. one had failed. i missed it. - https://github.com/pyOpenSci/pyosMeta/actions/runs/10201975001/job/28225084163#step:5:28 i'll submit a fix and won't be so rushed this time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants