Fix: bug in github username for reviewers) #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 58.95% 58.95%
=======================================
Files 8 8
Lines 519 519
Branches 82 82
=======================================
Hits 306 306
Misses 208 208
Partials 5 5 ☔ View full report in Codecov by Sentry. |
lwasser
commented
May 7, 2024
| @@ -30,12 +30,7 @@ | |||
| from pyosmeta.file_io import clean_export_yml, load_pickle | |||
| from pyosmeta.github_api import GitHubAPI | |||
| from pyosmeta.models import PersonModel | |||
|
|
|||
|
|
|||
| def get_clean_user(username: str) -> str: | |||
There was a problem hiding this comment.
moved this to the utils module as it makes more sense there.
lwasser
commented
May 7, 2024
| @@ -61,7 +56,9 @@ def main(): | |||
|
|
|||
| if gh_user not in contribs.keys(): | |||
| print("Found a new contributor!", gh_user) | |||
| new_contrib = process_contribs.get_user_info(gh_user) | |||
| new_contrib = process_contribs.return_user_info( | |||
There was a problem hiding this comment.
This was the cause of the actual first bug in CI
lwasser
commented
May 7, 2024
| 'githubusername' | ||
| """ | ||
|
|
||
| if len(username.split()) > 1: |
There was a problem hiding this comment.
Once the above bug was fixed another bug popped up related to a github username entered with a name after (and only a space).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small bug fix. this action hasn't been running in a few weeks because of this.