Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: parse up to 100 issues in a request #119

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 7, 2024

This will close #94
the simple fix to the pagination issue is to just change the api endpoint to increase from the default 30 to 100 per page. this PR implements that fix.

In a separate fix we can add pagination.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.00%. Comparing base (484102a) to head (ec02d39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files           4        4           
  Lines         459      459           
  Branches       73       73           
=======================================
  Hits          202      202           
  Misses        253      253           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwasser lwasser merged commit c7aed34 into pyOpenSci:main Mar 7, 2024
4 checks passed
@lwasser lwasser deleted the issues branch March 7, 2024 16:59
@willingc willingc added this to the March 2024 Release milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: GitHub request to increase perpage values to 100
2 participants