Skip to content

Commit

Permalink
Fix: add partners to contributors (#135)
Browse files Browse the repository at this point in the history
* Fix: add partners to contributors

* Fix: remove print statement from debugging
lwasser authored Mar 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 6fbb9cb commit a0cfaa8
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@
- Fix: Add tests for all utils functions (@lwasser, #122)
- Fix: Bug where date_accepted is removed (@lwasser, #129)
- Fix: Refactor all GitHub related methods move to gh_client module (@lwasser, #125)
- Add: support for partners and emeritus_editor in contributor model (@lwasser, #133)


## [v0.2.3] - 2024-02-29
2 changes: 1 addition & 1 deletion src/pyosmeta/cli/update_contributors.py
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ def main():
"software-peer-review",
"pyopensci.github.io",
"software-review",
"update-web-metadata",
"pyosmeta",
]
json_files = create_paths(repos)

6 changes: 6 additions & 0 deletions src/pyosmeta/models.py
Original file line number Diff line number Diff line change
@@ -96,6 +96,9 @@ class PersonModel(BaseModel, UrlValidatorMixin):
editorial_board: Optional[bool] = Field(
None, validation_alias=AliasChoices("editorial-board")
)
emeritus_editor: Optional[bool] = Field(
None, validation_alias=AliasChoices("emeritus_editor")
)
advisory: Optional[bool] = False
twitter: Optional[str] = Field(
None, validation_alias=AliasChoices("twitter_username")
@@ -104,6 +107,7 @@ class PersonModel(BaseModel, UrlValidatorMixin):
None, validation_alias=AliasChoices("mastodon_username", "mastodon")
)
orcidid: Optional[str] = None
partners: Optional[list[str]] = None
website: Optional[str] = Field(
None, validation_alias=AliasChoices("blog", "website")
)
@@ -124,6 +128,8 @@ class PersonModel(BaseModel, UrlValidatorMixin):
)
@classmethod
def convert_to_set(cls, value: list[str]):
"""This method converts any list of things ingested into the
model into a set object for cleaner parsing"""
if isinstance(value, list):
if not value:
return set()

0 comments on commit a0cfaa8

Please sign in to comment.