fix: force create joss cross ref badge #524
Conversation
| {% if raw_string contains "github.com" %} | ||
| <!-- If github is in the link, it's a link to a tag --> | ||
| <li> | ||
| <a href="{{ raw_string }}" rel="permalink"> |
There was a problem hiding this comment.
This parses the string to determine what type or url it is. We could do this in pyosmeta to make life easier potentially. If it's a latest DOI, maybe we just use those words vs the archive. it's still a valid citation.
this also will fail if the DOI provided is off in some way (i haven't figured out why some are off but i'm assuming there could be typos etc).
| {% endif %} | ||
| {% if apackage.astropy %} | ||
| True |
There was a problem hiding this comment.
This is the line that currently isn't working for some reason. It could be that we need a better flag or it could be that it has to parse the list of communities associated with the package (which is likely the case).
|
points of failure now make sense - one is a bad website url. the second is a bad day (that I can see when we parse our packages but haven't debugged to understand the why. Both of these items could be fixed via pyos meta if we do url validation. I set up URL validation for personal websites (grabbed from people's GitHub profiles). it would be easy also to check docs and dois as we parse them. This means we'd have to do less work on the website at the end of things.
|
|
this is what the page looks like now we could merge this as is if people agree as it patches a handful of bugs. Then fix pyosmeta in december when I have a bit more help to handle the bigger workflow issues that this patches over with conditional statements :) !! |
let's see if this addresses #517