Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automate the first stage model T and update DML notebook #172

Merged
merged 11 commits into from
Nov 21, 2019
Merged

automate the first stage model T and update DML notebook #172

merged 11 commits into from
Nov 21, 2019

Conversation

heimengqi
Copy link
Contributor

No description provided.

@heimengqi heimengqi self-assigned this Nov 19, 2019
@heimengqi heimengqi added the enhancement New feature or request label Nov 19, 2019
vasilismsr
vasilismsr suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@vasilismsr vasilismsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Missing docstring updates and also model_y default seems wrong.

econml/dml.py Outdated Show resolved Hide resolved
econml/dml.py Outdated Show resolved Hide resolved
econml/dml.py Outdated Show resolved Hide resolved
econml/dml.py Show resolved Hide resolved
moprescu
moprescu suggested changes Nov 19, 2019
View reviewed changes
econml/utilities.py Outdated Show resolved Hide resolved
econml/utilities.py Outdated Show resolved Hide resolved
econml/utilities.py Outdated Show resolved Hide resolved
econml/utilities.py Outdated Show resolved Hide resolved
econml/utilities.py Outdated Show resolved Hide resolved
@moprescu
Copy link
Contributor

Also, add some tests to test_dml where the auto option is being passed in and dml uses weights to make sure the E2E integration works. These tests would've caught the lack of sample_weight argument.

@heimengqi heimengqi requested a review from vasilismsr November 20, 2019 20:04
@moprescu moprescu merged commit 818c832 into master Nov 21, 2019
@heimengqi heimengqi deleted the mehei/modelautomation branch November 21, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasilismsr vasilismsr vasilismsr approved these changes

@moprescu moprescu moprescu approved these changes

Assignees

@heimengqi heimengqi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heimengqi @moprescu @vasilismsr