Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI: Remove b_ calls #992

Merged
merged 4 commits into from
Jun 14, 2022
Merged

PI: Remove b_ calls #992

merged 4 commits into from
Jun 14, 2022

Conversation

MartinThoma
Copy link
Member

See also: #986

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #992 (dbada88) into main (f0cd829) will not change coverage.
The diff coverage is 86.33%.

❗ Current head dbada88 differs from pull request most recent head 233b9ee. Consider uploading reports for the commit 233b9ee to get more accurate results

@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files          18       18           
  Lines        4179     4179           
  Branches      887      886    -1     
=======================================
  Hits         3528     3528           
  Misses        468      468           
  Partials      183      183           
Impacted Files Coverage Δ
PyPDF2/_reader.py 79.47% <62.50%> (ø)
PyPDF2/_security.py 97.40% <75.00%> (ø)
PyPDF2/_writer.py 88.16% <87.50%> (ø)
PyPDF2/generic.py 89.70% <92.13%> (ø)
PyPDF2/_utils.py 98.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712c16d...233b9ee. Read the comment docs.

@MartinThoma MartinThoma merged commit 8f5201e into main Jun 14, 2022
@MartinThoma MartinThoma deleted the b-2 branch June 14, 2022 18:27
@MartinThoma MartinThoma mentioned this pull request Jun 14, 2022
MartinThoma added a commit that referenced this pull request Jun 17, 2022
Performance Improvements (PI):
-  Remove b_ calls (#992, #986)
-  Apply improvements to _utils suggested by perflint (#993)

Robustness (ROB):
-  utf-16-be\' codec can\'t decode (...) (#995)

Documentation (DOC):
-  Remove reference to Scripts (#987)

Developer Experience (DEV):
-  Fix type annotations for add_bookmarks (#1000)

Testing (TST):
-  Add test for PdfMerger (#1001)
-  Add tests for XMP information (#996)
-  reader.get_fields / zlib issue / LZW decode issue (#1004)
-  reader.get_fields with report generation (#1002)
-  Improve test coverage by extracting texts (#998)

Code Style (STY):
-  Apply fixes suggested by pylint (#999)

Full Changelog: 2.2.0...2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant