Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .python-version #944

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Delete .python-version #944

merged 1 commit into from
Jun 4, 2022

Conversation

HarHarLinks
Copy link
Contributor

I believe this file made it into the source by error.
For example, the README lists 3.6 through 3.10 as supported, but this file would limit to 3.6.15.

Additionally, its inclusion unnecessarily limits the ability to install it, see https://aur.archlinux.org/packages/python-pypdf2#comment-868046

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #944 (9913e81) into main (98b4739) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files          16       16           
  Lines        4342     4342           
  Branches      821      821           
=======================================
  Hits         3401     3401           
  Misses        754      754           
  Partials      187      187           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b4739...9913e81. Read the comment docs.

@MartinThoma
Copy link
Member

Huh, interesting. Yes, it was added by accident. I use with pyenv to ensure I test with Python 3.6 (the one with the highest risk that it wouldn't work).

Thank you! I'll release a patch in a few minutes!

@MartinThoma MartinThoma merged commit 0358e20 into py-pdf:main Jun 4, 2022
@MartinThoma
Copy link
Member

I've just noticed that this file is not distributed to PyPI; the issue was with the cloned repository. As this is now fixed (thanks again :-) ) I'll not make a PyPI release.

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Jun 5, 2022

it's nice that it isnt in the pypi release, but it was in the source tarball release that is used to build the AUR package for example.
this means that this way of distribution needs the hotfix release.
thanks for your quick response.

MartinThoma added a commit that referenced this pull request Jun 6, 2022
The highlight of the 2.1.0 release is the most massive improvement to the
text extraction capabilities of PyPDF2 since 2016 🥳🎊 A very big thank you goes
to [pubpub-zz](https://github.com/pubpub-zz) who took a lot of time and
knowledge about the PDF format to finally get those improvements into PyPDF2.
Thank you 🤗💚

In case the new function causes any issues, you can use `_extract_text_old`
for the old functionality. Please also open a bug ticket in that case.

There were several people who have attempted to bring similar improvements to
PyPDF2. All of those were valuable. The main reason why they didn't get merged
is the big amount of open PRs / issues. pubpub-zz was the most comprehensive
PR which also incorporated the latest changes of PyPDF2 2.0.0.

Thank you to [VictorCarlquist](https://github.com/VictorCarlquist) for #858 and
[asabramo](https://github.com/asabramo) for #464 🤗

New Features (ENH):
-  Massive text extraction improvement (#924). Closed many open issues:
    - Exceptions / missing spaces in extract_text() method (#17) 🕺
      - Whitespace issues in extract_text() (#42) 💃
      - pypdf2 reads the hifenated words in a new line (#246)
    - PyPDF2 failing to read unicode character (#37)
      - Unable to read bullets (#230)
    - ExtractText yields nothing for apparently good PDF (#168) 🎉
    - Encoding issue in extract_text() (#235)
    - extractText() doesn't work on Chinese PDF (#252)
    - encoding error (#260)
    - Trouble with apostophes in names in text "O'Doul" (#384)
    - extract_text works for some PDF files, but not the others (#437)
    - Euro sign not being recognized by extractText (#443)
    - Failed extracting text from French texts (#524)
    - extract_text doesn't extract ligatures correctly (#598)
    - reading spanish text - mark convert issue (#635)
    - Read PDF changed from text to random symbols (#654)
    - .extractText() reads / as 1. (#789)
-  Update glyphlist (#947) - inspired by #464
-  Allow adding PageRange objects (#948)

Bug Fixes (BUG):
-  Delete .python-version file (#944)
-  Compare StreamObject.decoded_self with None (#931)

Robustness (ROB):
-  Fix some conversion errors on non conform PDF (#932)

Documentation (DOC):
-  Elaborate on PDF text extraction difficulties (#939)
-  Add logo (#942)
-  rotate vs Transformation().rotate (#937)
-  Example how to use PyPDF2 with AWS S3 (#938)
-  How to deprecate (#930)
-  Fix typos on robustness page (#935)
-  Remove scripts (pdfcat) from docs (#934)

Developer Experience (DEV):
-  Ignore .python-version file
-  Mark deprecated code with no-cover (#943)
-  Automatically create Github releases from tags (#870)

Testing (TST):
-  Text extraction for non-latin alphabets (#954)
-  Ignore PdfReadWarning in benchmark (#949)
-  writer.remove_text (#946)
-  Add test for Tree and _security (#945)

Code Style (STY):
-  black, isort, Flake8, splitting buildCharMap (#950)

Full Changelog: 2.0.0...2.1.0
@HarHarLinks
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants