Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add add_transformation method #883

Merged
merged 5 commits into from
May 22, 2022
Merged

Conversation

MartinThoma
Copy link
Member

No description provided.

@MartinThoma
Copy link
Member Author

Those two do not give the same results:

from PyPDF2 import PdfFileReader, PdfFileWriter, Transformation

for separated in [True, False]:
    reader_base = PdfFileReader("labeled-edges-center-image.pdf")
    page_base = reader_base.pages[0]

    reader = PdfFileReader("box.pdf")
    page_box = reader.pages[0]

    # Apply the transformation: Be aware, that this is an in-place operation
    op = Transformation().scale(2).rotate(45)
    if separated:
        page_box.add_transformation(op, expand=True)
        page_base.mergePage(page_box, expand=True)
    else:
        page_base.mergeTransformedPage(page_box, op, expand=False)

    # Write the result back
    writer = PdfFileWriter()
    writer.addPage(page_base)
    with open(f"merged-separeted-{separated}.pdf", "wb") as fp:
        writer.write(fp)

Something seems to be wrong about the mediabox / trimbox

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #883 (e3d56a8) into 2.0.0-dev (5703b61) will increase coverage by 0.09%.
The diff coverage is 88.23%.

@@              Coverage Diff              @@
##           2.0.0-dev     #883      +/-   ##
=============================================
+ Coverage      82.75%   82.84%   +0.09%     
=============================================
  Files             16       16              
  Lines           3758     3790      +32     
  Branches         798      808      +10     
=============================================
+ Hits            3110     3140      +30     
+ Misses           472      471       -1     
- Partials         176      179       +3     
Impacted Files Coverage Δ
PyPDF2/_page.py 84.68% <85.71%> (+0.67%) ⬆️
PyPDF2/generic.py 86.28% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5703b61...e3d56a8. Read the comment docs.

@MartinThoma MartinThoma force-pushed the refactor-transformations branch from b4901da to a735427 Compare May 22, 2022 05:55
@MartinThoma MartinThoma force-pushed the refactor-transformations branch from a735427 to 3094b4e Compare May 22, 2022 05:58
@MartinThoma MartinThoma merged commit adee9f0 into 2.0.0-dev May 22, 2022
@MartinThoma MartinThoma deleted the refactor-transformations branch May 22, 2022 06:32
MartinThoma added a commit that referenced this pull request Jun 1, 2022
The 2.0.0 release of PyPDF2 includes three core changes:

1. Dropping support for Python 3.5 and older.
2. Introducing type annotations.
3. Interface changes, mostly to have PEP8-compliant names

We introduced a [deprecation process](#930)
that hopefully helps users to avoid unexpected breaking changes.

Breaking Changes(DEP):
- PyPDF2 2.0 requires Python 3.6+. Python 2.7 and 3.5 support were dropped.
- PdfFileReader: The "warndest" parameter was removed
- PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`
  parameter. The new behavior is `overwriteWarnings=False`.
- merger: OutlinesObject was removed without replacement.
- merger.py ➔ _merger.py: You must import PdfFileMerger from PyPDF2 directly.
- utils:
  * `ConvertFunctionsToVirtualList` was removed
  * `formatWarning` was removed
  * `isInt(obj)`: Use `instance(obj, int)` instead
  * `u_(s)`: Use `s` directly
  * `chr_(c)`: Use `chr(c)` instead
  * `barray(b)`: Use `bytearray(b)` instead
  * `isBytes(b)`: Use `instance(b, type(bytes()))` instead
  * `xrange_fn`: Use `range` instead
  * `string_type`: Use `str` instead
  * `isString(s)`: Use `instance(s, str)` instead
  * `_basestring`: Use `str` instead
  * All Exceptions are now in `PyPDF2.errors`:
    - PageSizeNotDefinedError
    - PdfReadError
    - PdfReadWarning
    - PyPdfError
- `PyPDF2.pdf` (the `pdf` module) no longer exists. The contents were moved with
  the library. You should most likely import directly from `PyPDF2` instead.
  The `RectangleObject` is in `PyPDF2.generic`.
- The `Resources`, `Scripts`, and `Tests` will no longer be part of the distribution
  files on PyPI. This should have little to no impact on most people. The
  `Tests` are renamed to `tests`, the `Resources` are renamed to `resources`.
  Both are still in the git repository. The `Scripts` are now in
  https://github.com/py-pdf/cpdf. `Sample_Code` was moved to the `docs`.

For a full list of deprecated functions, please see the changelog of version
1.28.0.

New Features (ENH):
-  Improve space setting for text extraction (#922)
-  Allow setting the decryption password in PdfReader.__init__ (#920)
-  Add Page.add_transformation (#883)

Bug Fixes (BUG):
-  Fix error adding transformation to page without /Contents (#908)

Robustness (ROB):
-  Cope with invalid length in streams (#861)

Documentation (DOC):
-  Fix style of 1.25 and 1.27 patch notes (#927)
-  Transformation (#907)

Developer Experience (DEV):
-  Create flake8 config file (#916)
-  Use relative imports (#875)

Maintenance (MAINT):
-  Use Python 3.6 language features (#849)
-  Add wrapper function for PendingDeprecationWarnings (#928)
-  Use new PEP8 compliant names (#884)
-  Explicitly represent transformation matrix (#878)
-  Inline PAGE_RANGE_HELP string (#874)
-  Remove unnecessary generics imports (#873)
-  Remove star imports (#865)
-  merger.py ➔ _merger.py (#864)
-  Type annotations for all functions/methods (#854)
-  Add initial type support with mypy (#853)

Testing (TST):
-  Regression test for xmp_metadata converter (#923)
-  Checkout submodule sample-files for benchmark
-  Add text extracting performance benchmark
-  Use new PyPDF2 API in benchmark (#902)
-  Make test suite fail for uncaught warnings (#892)
-  Remove -OO testrun from CI (#901)
-  Improve tests for convert_to_int (#899)

Full Changelog: 1.28.4...2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant