Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default to strict=False in PdfFileReader/PdfFileMerger #848

Merged
merged 1 commit into from
May 1, 2022

Conversation

MartinThoma
Copy link
Member

It's expected that this is a more sensible default for most users.

@MartinThoma MartinThoma changed the title Change default to strict=False in PdfFileReader and PdfFileMerger Change default to strict=False in PdfFileReader/PdfFileMerger May 1, 2022
It's expected that this is a more sensible default for most users.
@MartinThoma MartinThoma force-pushed the default-strict-false branch from 34b2767 to 44e457a Compare May 1, 2022 12:07
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #848 (44e457a) into 2.0.0-dev (3713c8f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           2.0.0-dev     #848   +/-   ##
==========================================
  Coverage      82.50%   82.50%           
==========================================
  Files             15       15           
  Lines           3612     3612           
  Branches         775      775           
==========================================
  Hits            2980     2980           
  Misses           469      469           
  Partials         163      163           
Impacted Files Coverage Δ
PyPDF2/_reader.py 81.42% <100.00%> (ø)
PyPDF2/merger.py 70.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3713c8f...44e457a. Read the comment docs.

@MartinThoma MartinThoma merged commit 5c9df42 into 2.0.0-dev May 1, 2022
@MartinThoma MartinThoma deleted the default-strict-false branch May 1, 2022 12:09
MartinThoma added a commit that referenced this pull request May 2, 2022
It's expected that this is a more sensible default for most users.
MartinThoma added a commit that referenced this pull request May 2, 2022
It's expected that this is a more sensible default for most users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant