-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Apply pre-commit #832
Merged
Merged
+1,870
−1,137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change standardizes the code formatting quite a bit. Having standardized formatting makes the code easier to read and reduces the diff. This includes: * Applying the black auto-formatter (also in the docs) * Applying isort for import sorting * Making sure that files end with a newline
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 80.62% 80.72% +0.10%
==========================================
Files 12 12
Lines 3572 3627 +55
Branches 821 798 -23
==========================================
+ Hits 2880 2928 +48
- Misses 511 521 +10
+ Partials 181 178 -3
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
Apr 28, 2022
This change standardizes the code formatting quite a bit. Having standardized formatting makes the code easier to read and reduces the diff. This includes: * Applying the black auto-formatter (also in the docs) * Applying isort for import sorting * Making sure that files end with a newline Additionally, in several places the property function call style was replaced by the decorator style
VictorCarlquist
pushed a commit
to VictorCarlquist/PyPDF2
that referenced
this pull request
Apr 29, 2022
…df#832) This change standardizes the code formatting quite a bit. Having standardized formatting makes the code easier to read and reduces the diff. This includes: * Applying the black auto-formatter (also in the docs) * Applying isort for import sorting * Making sure that files end with a newline Additionally, in several places the property function call style was replaced by the decorator style
MartinThoma
added a commit
that referenced
this pull request
May 1, 2022
Robustness (ROB): - Handle missing destinations in reader (#840) - warn-only in readStringFromStream (#837) - Fix corruption in startxref or xref table (#788 and #830) Documentation (DOC): - Project Governance (#799) - History of PyPDF2 - PDF feature/version support (#816) - More details on text parsing issues (#815) Developer Experience (DEV): - Add benchmark command to Makefile - Ignore IronPython parts for code coverage (#826) Maintenance (MAINT): - Split pdf module (#836) - Separated CCITTFax param parsing/decoding (#841) - Update requirements files Testing (TST): - Use external repository for larger/more PDFs for testing (#820) - Swap incorrect test names (#838) - Add test for PdfFileReader and page properties (#835) - Add tests for PyPDF2.generic (#831) - Add tests for utils, form fields, PageRange (#827) - Add test for ASCII85Decode (#825) - Add test for FlateDecode (#823) - Add test for filters.ASCIIHexDecode (#822) Code Style (STY): - Apply pre-commit (black, isort) + use snake_case variables (#832) - Remove debug code (#828) - Documentation, Variable names (#839) Full Changelog: 1.27.9...1.27.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change standardizes the code formatting quite a bit.
Having standardized formatting makes the code easier to read
and reduces the diff.
This includes:
For the 52 open pull requests, merge conflicts are easiest to avoid by applying
black
directly on the current code in the PR.