Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply pre-commit #832

Merged
merged 4 commits into from
Apr 28, 2022
Merged

STY: Apply pre-commit #832

merged 4 commits into from
Apr 28, 2022

Conversation

MartinThoma
Copy link
Member

@MartinThoma MartinThoma commented Apr 28, 2022

This change standardizes the code formatting quite a bit.
Having standardized formatting makes the code easier to read
and reduces the diff.

This includes:

  • Applying the black auto-formatter (also in the docs)
  • Applying isort for import sorting
  • Making sure that files end with a newline

For the 52 open pull requests, merge conflicts are easiest to avoid by applying black directly on the current code in the PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This change standardizes the code formatting quite a bit.
Having standardized formatting makes the code easier to read
and reduces the diff.

This includes:

* Applying the black auto-formatter (also in the docs)
* Applying isort for import sorting
* Making sure that files end with a newline
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #832 (8eb2ed3) into main (865d744) will increase coverage by 0.10%.
The diff coverage is 66.46%.

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   80.62%   80.72%   +0.10%     
==========================================
  Files          12       12              
  Lines        3572     3627      +55     
  Branches      821      798      -23     
==========================================
+ Hits         2880     2928      +48     
- Misses        511      521      +10     
+ Partials      181      178       -3     
Impacted Files Coverage Δ
PyPDF2/pdf.py 82.22% <ø> (+0.01%) ⬆️
PyPDF2/merger.py 68.07% <52.50%> (ø)
PyPDF2/generic.py 84.91% <55.97%> (+0.30%) ⬆️
PyPDF2/filters.py 74.01% <81.53%> (ø)
PyPDF2/xmp.py 50.27% <93.75%> (ø)
PyPDF2/__init__.py 100.00% <100.00%> (ø)
PyPDF2/pagerange.py 100.00% <100.00%> (ø)
PyPDF2/utils.py 93.60% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865d744...8eb2ed3. Read the comment docs.

@MartinThoma MartinThoma merged commit eef03d9 into main Apr 28, 2022
@MartinThoma MartinThoma deleted the autoformatting branch April 28, 2022 09:53
MartinThoma added a commit that referenced this pull request Apr 28, 2022
This change standardizes the code formatting quite a bit.
Having standardized formatting makes the code easier to read
and reduces the diff.

This includes:

* Applying the black auto-formatter (also in the docs)
* Applying isort for import sorting
* Making sure that files end with a newline

Additionally, in several places the property function call style was replaced by the decorator style
VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this pull request Apr 29, 2022
…df#832)

This change standardizes the code formatting quite a bit.
Having standardized formatting makes the code easier to read
and reduces the diff.

This includes:

* Applying the black auto-formatter (also in the docs)
* Applying isort for import sorting
* Making sure that files end with a newline

Additionally, in several places the property function call style was replaced by the decorator style
MartinThoma added a commit that referenced this pull request May 1, 2022
Robustness (ROB):
-  Handle missing destinations in reader (#840)
-  warn-only in readStringFromStream (#837)
-  Fix corruption in startxref or xref table (#788 and #830)

Documentation (DOC):
-  Project Governance (#799)
-  History of PyPDF2
-  PDF feature/version support (#816)
-  More details on text parsing issues (#815)

Developer Experience (DEV):
-  Add benchmark command to Makefile
-  Ignore IronPython parts for code coverage (#826)

Maintenance (MAINT):
-  Split pdf module (#836)
-  Separated CCITTFax param parsing/decoding (#841)
-  Update requirements files

Testing (TST):
-  Use external repository for larger/more PDFs for testing (#820)
-  Swap incorrect test names (#838)
-  Add test for PdfFileReader and page properties (#835)
-  Add tests for PyPDF2.generic (#831)
-  Add tests for utils, form fields, PageRange (#827)
-  Add test for ASCII85Decode (#825)
-  Add test for FlateDecode (#823)
-  Add test for filters.ASCIIHexDecode (#822)

Code Style (STY):
-  Apply pre-commit (black, isort) + use snake_case variables (#832)
-  Remove debug code (#828)
-  Documentation, Variable names (#839)

Full Changelog: 1.27.9...1.27.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant