Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: Invalid float object; use 0 as fallback #782

Merged
merged 2 commits into from
Apr 19, 2022
Merged

ROB: Invalid float object; use 0 as fallback #782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3426ad
ROB: Invalid float object; use 0 as fallback
MartinThoma Apr 19, 2022
5eb6363
Formatting
MartinThoma Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion PyPDF2/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import decimal
import re
import warnings
import logging

from PyPDF2.constants import FilterTypes as FT
from PyPDF2.constants import StreamAttributes as SA
Expand All @@ -57,6 +58,7 @@
u_,
)

logger = logging.getLogger(__name__)
ObjectPrefix = b_('/<[tf(n%')
NumberSigns = b_('+-')
IndirectPattern = re.compile(b_(r"[+-]?(\d+)\s+(\d+)\s+R[^a-zA-Z]"))
Expand Down Expand Up @@ -237,7 +239,13 @@ def __new__(cls, value="0", context=None):
try:
return decimal.Decimal.__new__(cls, utils.str_(value), context)
except Exception:
return decimal.Decimal.__new__(cls, str(value))
try:
return decimal.Decimal.__new__(cls, str(value))
except decimal.InvalidOperation:
# If this isn't a valid decimal (happens in malformed PDFs)
# fallback to 0
logger.warning("Invalid FloatObject {}".format(value))
return decimal.Decimal.__new__(cls, "0")

def __repr__(self):
if self == self.to_integral():
Expand Down