Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Import exceptions from PyPDF2.errors in PyPDF2.utils #780

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

MartinThoma
Copy link
Member

Closes #779

@codecov-commenter
Copy link

Codecov Report

Merging #780 (63c255d) into main (ac2aeea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #780   +/-   ##
=======================================
  Coverage   75.27%   75.28%           
=======================================
  Files          11       11           
  Lines        3507     3508    +1     
  Branches      809      809           
=======================================
+ Hits         2640     2641    +1     
  Misses        654      654           
  Partials      213      213           
Impacted Files Coverage Δ
PyPDF2/utils.py 91.32% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2aeea...63c255d. Read the comment docs.

@MartinThoma MartinThoma merged commit 90683ed into main Apr 19, 2022
@MartinThoma MartinThoma deleted the fix-errors-module branch April 19, 2022 11:11
MartinThoma added a commit that referenced this pull request Apr 19, 2022
Bug Fixes (BUG):
- Import exceptions from PyPDF2.errors in PyPDF2.utils (#780)

Code Style (STY):
-  Naming in 'make_changelog.py'
VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this pull request Apr 29, 2022
VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this pull request Apr 29, 2022
Bug Fixes (BUG):
- Import exceptions from PyPDF2.errors in PyPDF2.utils (py-pdf#780)

Code Style (STY):
-  Naming in 'make_changelog.py'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils.PdfReadError ➔ errors.PdfReadError (Breaking Change in 1.27.6)
2 participants