Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Deprecate with replacement CCITParameters #3019

Merged
merged 17 commits into from
Dec 25, 2024
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Dec 25, 2024

Deprecate CCITParameters with replacement CCITTParameters.

Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.36%. Comparing base (ddc23bb) to head (bd6ccf0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pypdf/filters.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   96.37%   96.36%   -0.01%     
==========================================
  Files          52       52              
  Lines        8767     8771       +4     
  Branches     1595     1595              
==========================================
+ Hits         8449     8452       +3     
- Misses        190      191       +1     
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Please make sure to keep coverage by ensuring that the old name still works as intended.

pypdf/filters.py Outdated Show resolved Hide resolved
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
@j-t-1
Copy link
Contributor Author

j-t-1 commented Dec 25, 2024

Please make sure to keep coverage by ensuring that the old name still works as intended.

Added. The check on 511 is indirect, so I think is okay now.

Deprecate CCITParameters with replacement CCITTParameters.
Deprecate CCITParameters with replacement CCITTParameters.
@stefan6419846 stefan6419846 merged commit ccdd2e5 into py-pdf:main Dec 25, 2024
14 of 16 checks passed
@j-t-1 j-t-1 deleted the CCITT branch December 25, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants