BUG: Handle IndirectObject in media boxes #2460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FloatObject constructor swallowed all exceptions, which masked issues where IndirectObject was incorrectly passed into the constructor. Instead, follow the pattern NumberObject does, and only swallow ValueError from malformed PDFs.
If an IndirectObject is passed as a parameter to the RectangleObject constructor, unwrap it so we use the number/float it contains.
SamStephens
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 49 49
Lines 8008 8019 +11
Branches 1616 1618 +2
=======================================
+ Hits 7562 7573 +11
Misses 276 276
Partials 170 170 ☔ View full report in Codecov by Sentry. |
Ensures we only go to a maximum depth, so a malicious PDF cannot get us indefinitely stuck. Also introduces unit tests.
pubpub-zz
added a commit
to pubpub-zz/pypdf
that referenced
this pull request
Feb 20, 2024
alternative solution to py-pdf#2460 fixes py-pdf#2287
|
I've proposed an alternative that should cover more cases |
stefan6419846
pushed a commit
that referenced
this pull request
Feb 25, 2024
|
Thanks for your proposal. I decided to go with #2464 which covers this issue in a more generic manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where passing an
IndirectObjectto the constructor ofFloatObjectemitted a warning and resulting in a value of0.0, rather than an exception being thrown.When an
IndirectObjectis passed to the constructor ofRectangleObject, unwrap thatIndirectObjectso the number it contains is used; this allows for PDFs with page dimensions that includeIndirectObjects.Fixes #2287