Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add missing pytest.mark.samples annotations #2412

Merged
merged 4 commits into from
Jan 17, 2024
Merged

TST: Add missing pytest.mark.samples annotations #2412

merged 4 commits into from
Jan 17, 2024

Conversation

kitterma
Copy link
Contributor

@kitterma kitterma commented Jan 15, 2024 •
edited by MartinThoma
Loading

Closes #2407

This was referenced Jan 15, 2024
Closed
Closed
@kitterma kitterma changed the title Update pytest.mark for multiple tests TST: Update pytest.mark for multiple tests Jan 15, 2024
stefan6419846
stefan6419846 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

MartinThoma
MartinThoma reviewed Jan 17, 2024
View reviewed changes
tests/test_writer.py Outdated Show resolved Hide resolved
MartinThoma
MartinThoma reviewed Jan 17, 2024
View reviewed changes
tests/test_reader.py Outdated Show resolved Hide resolved
MartinThoma
MartinThoma reviewed Jan 17, 2024
View reviewed changes
tests/test_reader.py Outdated Show resolved Hide resolved
MartinThoma
MartinThoma reviewed Jan 17, 2024
View reviewed changes
tests/test_reader.py Outdated Show resolved Hide resolved
MartinThoma
MartinThoma reviewed Jan 17, 2024
View reviewed changes
tests/test_reader.py Outdated Show resolved Hide resolved
MartinThoma
MartinThoma reviewed Jan 17, 2024
View reviewed changes
tests/test_writer.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma changed the title TST: Update pytest.mark for multiple tests TST: Add missing pytest.mark.samples annotations Jan 17, 2024
@MartinThoma MartinThoma merged commit 0277352 into py-pdf:main Jan 17, 2024
14 checks passed
@MartinThoma
Copy link
Member

Thank you for your contribution!

I've removed 3 lines I was uncertain about: Two where the samples-annotation should actually not be there (I hope I didn't miss something 😅 ) and the #2408 part. I think that one would have belonged two lines below (within the test); but I'm also uncertain if we should do it in the first place.

@MartinThoma
Copy link
Member

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

@kitterma
Copy link
Contributor Author

Yes please. Thanks. I'll have a look at the others again later.

MartinThoma added a commit that referenced this pull request Jan 19, 2024
@MartinThoma
REL: 4.0.0
26b9a97 
## What's new

pypdf==4.0.0 is a big milestone forward:

* We finally have a layout-mode text extraction.
  This enables users who want to detect / extract tables
  with heuristics to give it a try.
* We deprecated a lot of the old PyPDF2 API that was either
  not following PEP8 naming styles or was not using a
  property. Users comming from PyPDF2 might want to switch
  first to pypdf<4.0.0 to get helpful error messages
  that show the new API in their speicific cases.

A big 'Thank you!' the the whole pypdf community for your
work. Thanks to you, pypdf is better than ever.

Kudos to @shartzog who added the layout-mode with his first
contribution!

### Deprecations (DEP)
-  Drop Python 3.6 support (#2369) by @MartinThoma
-  Remove deprecated code (#2367) by @MartinThoma
-  Remove deprecated XMP properties (#2386) by @stefan6419846

### New Features (ENH)
-  Add "layout" mode for text extraction (#2388) by @shartzog
-  Add Jupyter Notebook integration for PdfReader (#2375) by @MartinThoma
-  Improve/rewrite PDF permission retrieval (#2400) by @stefan6419846

### Bug Fixes (BUG)
-  PdfWriter.add_uri was setting the wrong type (#2406) by @pmiller66
-  Add support for GBK2K cmaps (#2385) by @stefan6419846

### Documentation (DOC)
-  Add pmiller66 for #2406 as a contributor by @MartinThoma
-  Add missing expand parameter (#2393) by @Atomnp
-  Resolve build warnings (#2380) by @stefan6419846
-  Fix testing prerequisites (#2381) by @stefan6419846
-  Improve formatting of contributors page (#2383) by @stefan6419846
-  Add Tobeabellwether as a contributor for #2341 by @MartinThoma

### Developer Experience (DEV)
-  Make dependabot aware of our PR prefixes (#2415) by @stefan6419846
-  Fail on Sphinx issues (#2405) by @stefan6419846
-  Move title check to own workflow (#2384) by @MasterOdin
-  Write to temporary files instead of the working directory (#2379) by @stefan6419846
-  Ensure that the PR titles have the correct format (#2378) by @stefan6419846

### Maintenance (MAINT)
-  Complete FileSpecificationDictionaryEntries constants (#2416) by @MartinThoma
-  Return None instead of -1 when page is not attached (#2376) by @MartinThoma
-  Replace warning with logging.error (#2377) by @MartinThoma

### Testing (TST)
-  Add missing pytest.mark.samples annotations (#2412) by @kitterma
-  Correctly close temporary files (#2396) by @stefan6419846
-  Fix  side effect #2379 (#2395) by @pubpub-zz
-  Add test for layout extraction mode (#2390) by @MartinThoma

### Code Style (STY)
-  Use the UserAccessPermissions enum (#2398) by @MartinThoma
-  Run black (#2370) by @MartinThoma

[Full Changelog](3.17.4...4.0.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

@MartinThoma MartinThoma MartinThoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing pytest.mark.samples
3 participants
@kitterma @MartinThoma @stefan6419846