Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cope with deflated images with CMYK Black Only #2322

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #2321

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
There seems to be an issue with test concurrency. is it normal ?

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (441bb59) 94.39% compared to head (ec4e1ca) 94.37%.

Files Patch % Lines
pypdf/_xobj_image_helpers.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2322      +/-   ##
==========================================
- Coverage   94.39%   94.37%   -0.03%     
==========================================
  Files          43       43              
  Lines        7655     7660       +5     
  Branches     1513     1515       +2     
==========================================
+ Hits         7226     7229       +3     
- Misses        266      267       +1     
- Partials      163      164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma changed the title cope with deflated images with CMYK Black Only BUG: cope with deflated images with CMYK Black Only Dec 2, 2023
@MartinThoma MartinThoma changed the title BUG: cope with deflated images with CMYK Black Only BUG: Cope with deflated images with CMYK Black Only Dec 2, 2023
@MartinThoma MartinThoma merged commit a3742ae into py-pdf:main Dec 2, 2023
12 of 14 checks passed
@MartinThoma
Copy link
Member

@pubpub-zz I've restarted the test and it worked. I'm not happy with the fact that our tests / the CI is flaky, but I don't know how to fix that :-/

@pubpub-zz
Copy link
Collaborator Author

pubpub-zz commented Dec 2, 2023

The issue seems to be due to use of the same "output" name in different tests which is preventing concurency:
I see two options :
a) use of BytesIO and no more writing to disk
b) customize the names with the current running test

a) may be better as concurency in b) can occur between different python tests sets

MartinThoma added a commit that referenced this pull request Dec 10, 2023
## What's new

### Bug Fixes (BUG)
-  Cope with deflated images with CMYK Black Only (#2322) by @pubpub-zz
-  Handle indirect objects as parameters for CCITTFaxDecode (#2307) by @stefan6419846
-  check words length in _cmap type1_alternative function (#2310) by @Takher

### Robustness (ROB)
-  Relax flate decoding for too many lookup values (#2331) by @stefan6419846
-  Let _build_destination skip in case of missing /D key (#2018) by @nickryand

### Documentation (DOC)
-  Note in reading form data (#2338) by @MartinThoma
-  Pull Request prefixes and size by @MartinThoma
-  Add https://github.com/zuypt for #2325 as a contributor by @MartinThoma
-  Fix docstring for RunLengthDecode.decode (#2302) by @stefan6419846

### Maintenance (MAINT)
-  Enable `disallow_any_generics` and add missing generics (#2278) by @nilehmann

### Testing (TST)
-  Centralize file downloads (#2324) by @MartinThoma

### Code Style (STY)
-  Fix typo "steam" \xe2\x86\x92 "stream" (#2327) by @stefan6419846
-  Run black by @MartinThoma
-  Make Traceback in bug report template uppercase (#2304) by @stefan6419846

[Full Changelog](3.17.1...3.17.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMYK image with filter_type equal to flate_decode return "not enough image data" error
2 participants