Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Improve merging docs #2247

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

stefan6419846
Copy link
Collaborator

@stefan6419846 stefan6419846 commented Oct 9, 2023

This reworks the docs on merging PDF files to quite some extent:

  • Formatting: Make it consistent
  • Language: Improve typos and formulations
  • Duplication: Avoid reproducing the complete parameter set of methods in the tutorial. Point to the API reference instead.
  • Content: Add an example for page.transfer_rotation_to_content().

Fixes #1655

@MartinThoma
Copy link
Member

@MartinThoma MartinThoma merged commit 8a4adac into py-pdf:main Oct 10, 2023
@MartinThoma
Copy link
Member

@stefan6419846 Thank you for the awesome improvement 🎉 🕺

@stefan6419846 stefan6419846 deleted the merging-docs branch October 10, 2023 19:09
@MartinThoma
Copy link
Member

I miss my dancing penguin emoji xD

MartinThoma added a commit that referenced this pull request Oct 29, 2023
## What's new

### Security (SEC)
-  Infinite recursion when using PdfWriter(clone_from=reader) (#2264) by @Alexhuszagh

### New Features (ENH)
-  Add parameter to select images to be removed (#2214) by @pubpub-zz

### Bug Fixes (BUG)
-  Correctly handle image mode 1 with FlateDecode (#2249) by @stefan6419846
-  Error when filling a value with parentheses #2268 (#2269) by @KanorUbu
-  Handle empty root outline (#2239) by @pubpub-zz

### Documentation (DOC)
-  Improve merging docs (#2247) by @stefan6419846

### Developer Experience (DEV)
-  Test Python 3.7 with cryptopgraphy provider as well (#2276) by @stefan6419846
-  Run CI with windows-latest (#2258) by @MartinThoma
-  Use pytest-xdist (#2254) by @MartinThoma
-  Attribute correct authors in the release notes (#2246) by @stefan6419846

### Maintenance (MAINT)
-  Apply pre-commit hooks (#2277) by @MartinThoma
-  Update requirements + mypy fixes (#2275) by @MartinThoma
-  Explicitly provide Any for IO generic argument (#2272) by @nilehmann

### Testing (TST)
-  Fix test_image_without_pillow in windows environment (#2257) by @pubpub-zz

### Code Style (STY)
-  Remove unused import by @MartinThoma

[Full Changelog](3.16.4...3.17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Documentation on merging rotated PDFs
2 participants