Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: clean-up overriden variable #2189

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

pubpub-zz
Copy link
Collaborator

closes #2181

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c587cee) 94.34% compared to head (24b2adc) 94.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2189   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          43       43           
  Lines        7572     7572           
  Branches     1488     1488           
=======================================
  Hits         7144     7144           
  Misses        263      263           
  Partials      165      165           
Files Changed Coverage Δ
pypdf/_codecs/adobe_glyphs.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma all yours

@MartinThoma MartinThoma merged commit 3617412 into py-pdf:main Sep 13, 2023
MartinThoma added a commit that referenced this pull request Sep 17, 2023
## What's new

### Bug Fixes (BUG)
-  Missing new line in extract_text with cm operations (#2142) by @pubpub-zz
-  _get_fonts not processing properly CIDFonts and annotations (#2194) by @pubpub-zz

### Documentation (DOC)
-  Sort list of contributors by @MartinThoma

### Developer Experience (DEV)
-  Give attribution in release notes (#2196) by @MartinThoma

### Maintenance (MAINT)
-  Update packages (#2195) by @MartinThoma
-  Rename PdfWriter.create_viewer_preferences to PdfWriter.create_viewer_preferences (#2190) by @marcstober
-  Mark `cryptography` as default (#2186) by @exiledkingcc

### Testing (TST)
-  Issue with merging pdfkit (#2191) by @MartinThoma

### Code Style (STY)
-   clean-up overriden variable (#2189) by @pubpub-zz

[Full Changelog](3.16.0...3.16.1)
@pubpub-zz pubpub-zz deleted the iss2181 branch August 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable declared and override in same file
2 participants