Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: catch the case where w[0] is an IndirectObject instead of an int #2154

Merged
merged 4 commits into from
Sep 10, 2023
Merged

BUG: catch the case where w[0] is an IndirectObject instead of an int #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
295728b
BUG: catch the case where w[0] is an `IndirectObject` instead of an int
rchen19 Sep 5, 2023
f92244e
BUG: add test for bug fix for issue #2137
rchen19 Sep 6, 2023
6d9f1fe
BUG: fix code stype errors in test for issue #2137
rchen19 Sep 6, 2023
dc0c8b5
Merge branch 'main' into BUG-TypeError-IndirectObject-object-cannot-b…
MartinThoma Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pypdf/_cmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def compute_space_width(
else:
w = []
while len(w) > 0:
st = w[0]
st = w[0] if isinstance(w[0], int) else w[0].get_object()
second = w[1].get_object()
if isinstance(second, int):
for x in range(st, second):
Expand Down
12 changes: 12 additions & 0 deletions tests/test_cmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,18 @@ def test_unixxx_glyphs():
assert pat in txt


@pytest.mark.enable_socket()
def test_cmap_compute_space_width():
# issue 2137
# original file URL:
url = "https://arxiv.org/pdf/2005.05909.pdf"
# URL from github issue is too long to pass code stype check, use original arxiv URL instead
# url = "https://github.com/py-pdf/pypdf/files/12489914/Morris.et.al.-.2020.-.TextAttack.A.Framework.for.Adversarial.Attacks.Data.Augmentation.and.Adversarial.Training.in.NLP.pdf"
name = "TextAttack_paper.pdf"
reader = PdfReader(BytesIO(get_data_from_url(url, name=name)))
reader.pages[0].extract_text() # no error


@pytest.mark.enable_socket()
def test_tabs_in_cmap():
"""Issue #2173"""
Expand Down