Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added encoding ability #2048

Closed
wants to merge 1 commit into from
Closed

Conversation

coolbombom
Copy link

Added encoding ability to update_page_form_field_values so functionality uses that encoding to populate from fields.

Fixes issue that i had:
#2035

Added encoding ability to update_page_form_field_values so functionality uses that encoding to populate from fields.

Fixes issue that i had:
py-pdf#2035
@pubpub-zz
Copy link
Collaborator

@coolbombom
From my analysis the mod is more tricky. Can you try this PR : #2047 (note this PR requires the latest night built to ensure to have
#2043 )

@MartinThoma MartinThoma changed the title added encoding ability ENH: Added encoding ability Jul 31, 2023
@MartinThoma MartinThoma added the is-feature A feature request label Jul 31, 2023
@pubpub-zz
Copy link
Collaborator

@MartinThoma
this is not a feature but a (wrong from my point of view) way to work around german characters encoding. the encoding is a consequence of the font selected.

@coolbombom
Copy link
Author

@pubpub-zz
I can confirm that #2047 fixes the issue

@pubpub-zz
Copy link
Collaborator

pubpub-zz commented Aug 1, 2023

I therefore propose to close this PR

@pubpub-zz pubpub-zz closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-feature A feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants